Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number: Added zero check for toPrecision #866

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@hmizutanitsi
Copy link
Contributor

commented Apr 16, 2019

Number: Added zero check for toPrecision

"formatNumber returns NaN for 0, if max/minimumSignificantDigits is set

Fixed: #706

@rxaviers

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Awesome, thank you for your fix. Please, can we add a unit test to confirm it?

@hmizutanitsi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

No problem! I added a case to test number==0.

@rxaviers

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Thank you!

@rxaviers rxaviers merged commit b494717 into globalizejs:master Apr 17, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.