Add Cache-Control and Expires HTTP headers in response

[dhardy92]

Hello,

This is a small patch to add some cache control in configuration.
If you use some caching technologies like varnishd in front of thumbor it could be usefull to add Cache-Control and Expires header to make varnish storing fine the generated image preventing request at thumbor to often.

I add some tests with it but wasn't able to make them working, all the tests ends with :
AssertionError: Async operation timed out after X seconds
Did I missed something ?

Best regards,

Damien

[heynemann]

Thanks a LOT Damien. We'll integrate asap.

Cheers,
Bernardo Heynemann

On Thu, Dec 29, 2011 at 1:44 PM, Damien Hardy <
reply@reply.github.com

wrote:

Hello,

This is a small patch to add some cache control in configuration.
If you use some caching technologies like varnishd in front of thumbor it
could be usefull to add Cache-Control and Expires header to make varnish
storing fine the generated image preventing request at thumbor to often.

I add some tests with it but wasn't able to make them working, all the
tests ends with :
AssertionError: Async operation timed out after X seconds
Did I missed something ?

Best regards,

Damien

You can merge this Pull Request by running:

git pull https://github.com/dhardy92/thumbor master

Or you can view, comment on it, or merge it online at:

#53

-- Commit Summary --

• add optional Cache-Control and Expires HTTP headers in response

-- File Changes --

M tests/test_handlers.py (11)
M thumbor/config.py (1)
M thumbor/handlers/init.py (5)

-- Patch Links --

https://github.com/globocom/thumbor/pull/53.patch
https://github.com/globocom/thumbor/pull/53.diff

---

Reply to this email directly or view it on GitHub:
#53

[heynemann]

Implemented this on master.

Thanks a LOT for contributing.