Support --myproxy-lifetime for endpoint activate #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endpoint activation via myproxy can take explicit lifetime in hours. Be slightly cautious to allow the value "0", which the API and GCS will happily use (though, of course, it's odd). Also, fix a minor, pedantic, "bug" in the treatment of myproxy activation requirements.
corpulentcoffee
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint activation via myproxy can take explicit lifetime in hours.
Be slightly cautious to allow the value "0", which the API and GCS will happily use (though, of course, it's odd).
Also, fix a minor, pedantic, "bug" in the treatment of myproxy activation requirements.
I had to spin up a myproxy endpoint to test this, but it works as expected as far as I can tell.
No legitimate unit testing seems possible at present.
Running with
--myproxy-lifetime 0is confusing, but I think ignoring or rejecting it is more confusing.Part of #388