Remove support and docs for optional dependencies #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
force-pushed
the
remove-opt-deps
branch
from
1e3e665
to
4321dec
Compare
Remove the opt dep error type, simplify usage of `jwt` to not try-except on its import, remove the opt deps docs page from the main TOC, but leave a stub version of the page in place. That way, anyone seeing a link to this page from the old exception message won't be sent to a 404 page right away. We can drop it at some point. Remove OptionalDependency stuff from tests. Closes globus#258
Wildcard imports were broken. We don't have anything else checking the contents of `__all__`, so this is a nice simple pair of tests to add. Also, remove the errant element from __all__ to fix the import.
The Appveyor build environment doesn't actually execute in the context of a virtualenv or anything like one. Instead, it gives you a preset python binary path to use. To handle this, use an env var to capture that value, and pull it out during the testsuite's subprocess invocations.
sirosen
force-pushed
the
remove-opt-deps
branch
from
96badda
to
d8466a2
Compare
sirosen
added a commit
to sirosen/globus-sdk-python
that referenced
this pull request
Dec 13, 2017
Changelog: - globus#261 Add OAuthTokenResponse.by_scopes - globus#257, globus#260 Make `cryptography` a strict requirement, `globus-sdk[jwt]` is no longer neecessary - globus#255 Simplify OAuthTokenResponse.decode_id_token to not require the client as an argument - globus#259 Add (beta) SearchClient class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the opt dep error type, simplify usage of
jwtto not try-except on its import, remove the opt deps docs page from the main TOC, but leave a stub version of the page in place. That way, anyone seeing a link to this page from the old exception message won't be sent to a 404 page right away. We can drop it at some point.Closes #258