Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency to doc build #377

Merged
merged 1 commit into from Aug 17, 2020
Merged

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Aug 14, 2020

Description

As pointed out by @csadorf, the build of the documentation is failing because it doesn't import the dependency we added in #359.

Here's the project on pypi to confirm that it can be installed with pip install.

Should we add pre-merge tests for the docs?

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

Example for a changelog entry: Fix issue with launching rockets to the moon (#101, #212).

@cbkerr cbkerr requested review from a team as code owners August 14, 2020 04:04
@cbkerr cbkerr requested review from atravitz and kidrahahjo and removed request for a team August 14, 2020 04:04
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #377 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   76.46%   76.46%           
=======================================
  Files          45       45           
  Lines        7133     7133           
=======================================
  Hits         5454     5454           
  Misses       1679     1679           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c530ce...34e9e35. Read the comment docs.

@cbkerr cbkerr requested review from csadorf and removed request for kidrahahjo August 14, 2020 04:05
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @cbkerr !

@b-butler b-butler removed the request for review from atravitz August 17, 2020 17:25
@b-butler b-butler merged commit 772c7b7 into master Aug 17, 2020
@b-butler b-butler deleted the fix/require-programoutput branch August 17, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants