Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Imgur token (authed upload) and Imgur albums. #1102

Merged
merged 5 commits into from Feb 1, 2020

Conversation

@Jaekr
Copy link
Contributor

Jaekr commented Jan 25, 2020

Added:

  • Authed upload: add a Imgur Bearer Token to upload directly into your Imgur account
  • Album upload (need to be authenticated): uploads the image and adds it into the selected album
js/imgur.js Outdated Show resolved Hide resolved
js/imgur.js Outdated Show resolved Hide resolved
js/imgur.js Outdated Show resolved Hide resolved
js/imgur.js Outdated Show resolved Hide resolved
js/imgur.js Outdated Show resolved Hide resolved
js/imgur.js Outdated Show resolved Hide resolved
js/imgur.js Outdated Show resolved Hide resolved
js/imgur.js Outdated Show resolved Hide resolved
@lorenzhs

This comment has been minimized.

Copy link
Member

lorenzhs commented Jan 27, 2020

Thanks @Jaekr, this is a nice addition. I already added a few inline comments, but there's one other thing. I would suggest moving the input fields into the settings dialog instead of the connection screen. For one, it doesn't have anything to do with connecting GB, and for another, if it's in settings, you can change it without reconnecting.

Please also don't commit the package-lock.json, npm is only used for the test environment and we don't really care about exact versions of anything.

js/imgur.js Outdated Show resolved Hide resolved
@Jaekr

This comment has been minimized.

Copy link
Contributor Author

Jaekr commented Jan 28, 2020

I'm gonna make the changes as fast as possible!

index.html Outdated Show resolved Hide resolved
@Jaekr

This comment has been minimized.

Copy link
Contributor Author

Jaekr commented Jan 30, 2020

That's all, it should be ok.

@lorenzhs lorenzhs force-pushed the Jaekr:master branch from 55f3e56 to 57aad0a Jan 31, 2020
@lorenzhs

This comment has been minimized.

Copy link
Member

lorenzhs commented Jan 31, 2020

All right, thanks a lot! I squashed it a bit and moved the configuration to the settings dialog, you can test the result at https://latest.glowing-bear.org/pull/1102/

js/imgur.js Outdated Show resolved Hide resolved
Jae Beojkkoch
@Jaekr

This comment has been minimized.

Copy link
Contributor Author

Jaekr commented Jan 31, 2020

Any last changes?

@lorenzhs lorenzhs merged commit cdfc518 into glowing-bear:master Feb 1, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lorenzhs

This comment has been minimized.

Copy link
Member

lorenzhs commented Feb 1, 2020

Thanks very much @Jaekr, this is a feature that's been requested a few times, I think you just made a few people quite happy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.