Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collector address with underscore raise exception #696

Open
devnewton opened this issue Mar 5, 2020 · 3 comments
Open

collector address with underscore raise exception #696

devnewton opened this issue Mar 5, 2020 · 3 comments

Comments

@devnewton
Copy link

@devnewton devnewton commented Mar 5, 2020

An exception is raised when collector.address value in glowroot.properties agent configuration file refer to a domain with underscores like this:

collector.address=http://my_machine.myzone.com:8181

Exception:

java.lang.IllegalArgumentException: Invalid host or port: my_machine.myzone.com 818 at org.glowroot.agent.shaded.io.grpc.internal.GrpcUtil.authorityFromHostAndPort(GrpcUtil.java:480) at org.glowroot.agent.shaded.io.grpc.netty.NettyChannelBuilder.<init>(NettyChannelBuilder.java:115) at org.glowroot.agent.shaded.io.grpc.netty.NettyChannelBuilder.forAddress(NettyChannelBuilder.java:101) at org.glowroot.agent.central.CentralConnection.<init>(CentralConnection.java:95) at org.glowroot.agent.central.CentralCollector.<init>(CentralCollector.java:135) at org.glowroot.agent.init.NonEmbeddedGlowrootAgentInit$1.run(NonEmbeddedGlowrootAgentInit.java:136) at org.glowroot.agent.impl.BytecodeServiceImpl.enteringMainMethod(BytecodeServiceImpl.java:255) at org.glowroot.agent.impl.BytecodeServiceImpl.enteringMainMethod(BytecodeServiceImpl.java:77) at org.glowroot.agent.bytecode.api.Bytecode.enteringMainMethod(Bytecode.java:32) at org.springframework.boot.loader.WarLauncher.main(WarLauncher.java) Caused by: java.net.URISyntaxException: Illegal character in hostname at index ...: //my_machine.myzone.com at java.base/java.net.URI$Parser.fail(URI.java:2913) at java.base/java.net.URI$Parser.parseHostname(URI.java:3448) at java.base/java.net.URI$Parser.parseServer(URI.java:3297) at java.base/java.net.URI$Parser.parseAuthority(URI.java:3216) at java.base/java.net.URI$Parser.parseHierarchical(URI.java:3158) at java.base/java.net.URI$Parser.parse(URI.java:3125) at java.base/java.net.URI.<init>(URI.java:685) at org.glowroot.agent.shaded.io.grpc.internal.GrpcUtil.authorityFromHostAndPort(GrpcUtil.java:478) ... 9 common frames omitted

@trask

This comment has been minimized.

Copy link
Member

@trask trask commented Mar 5, 2020

Hi @devnewton, what glowroot version are you using? Can you upload an exact copy of your glowroot.properties file?

@devnewton

This comment has been minimized.

Copy link
Author

@devnewton devnewton commented Mar 6, 2020

I have downloaded the glowroot-0.13.6-dist.zip release.

Here is my configuration file:
glowroot.zip

@trask

This comment has been minimized.

Copy link
Member

@trask trask commented Mar 8, 2020

Hi @devnewton, check out the explanation in grpc/grpc-java#3701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.