Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network ports display broken (typo) #5460

Closed
Stoatwblr opened this issue Feb 24, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Stoatwblr
Copy link

commented Feb 24, 2019

There's a typo in the 9.4 release code which breaks network port display for everything.
I am surprised no one spotted this in testing (don't testers use network ports?)

see https://forum.glpi-project.org/viewtopic.php?id=167743

glpi/inc/networkportinstantiation.class.php

line 289

-                  'WHERE'  => ['networkports_id_list' => ['LIKE', '%"'.$netport-getID().'"%']]
+                  'WHERE'  => ['networkports_id_list' => ['LIKE', '%"'.$netport->getID().'"%']]

There are no other instances of this particular typo in the code.
That does not mean there are other instances of "$this-something()"

@cedric-anne

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2019

Hi,

Could you test 5462 ?

I searched for \$\w+\s*-\s*\w+\s*\( in the code and did not find any other occurenc of this kind of typo.

Regards

@cedric-anne cedric-anne self-assigned this Feb 24, 2019

@cedric-anne cedric-anne added the bug label Feb 24, 2019

@cedric-anne cedric-anne added this to the 9.4.1 milestone Feb 24, 2019

@trasher trasher closed this in c471f9d Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.