diff --git a/src/ChangeTask.php b/src/ChangeTask.php index 78a875adf26..d52ade6e5b4 100644 --- a/src/ChangeTask.php +++ b/src/ChangeTask.php @@ -44,7 +44,7 @@ public static function getTypeName($nb = 0) /** * Populate the planning with planned ticket tasks * - * @param $options array of possible options: + * @param array $options array of possible options: * - who ID of the user (0 = undefined) * - whogroup ID of the group of users (0 = undefined) * - begin Date @@ -76,7 +76,7 @@ public static function displayPlanningItem(array $val, $who, $type = "", $comple /** * Populate the planning with not planned ticket tasks * - * @param $options array of possible options: + * @param array $options array of possible options: * - who ID of the user (0 = undefined) * - whogroup ID of the group of users (0 = undefined) * - begin Date diff --git a/src/Change_Problem.php b/src/Change_Problem.php index af01758ef7b..5afb95bc5b7 100644 --- a/src/Change_Problem.php +++ b/src/Change_Problem.php @@ -102,6 +102,7 @@ public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $ * Show tickets for a problem * * @param Problem $problem + * @return void **/ public static function showForProblem(Problem $problem) { @@ -109,7 +110,7 @@ public static function showForProblem(Problem $problem) $ID = $problem->getField('id'); if (!$problem->can($ID, READ)) { - return false; + return; } $canedit = $problem->canEdit($ID); @@ -194,6 +195,7 @@ public static function showForProblem(Problem $problem) * Show problems for a change * * @param Change $change object + * @return void **/ public static function showForChange(Change $change) { @@ -201,7 +203,7 @@ public static function showForChange(Change $change) $ID = $change->getField('id'); if (!$change->can($ID, READ)) { - return false; + return; } $canedit = $change->canEdit($ID); diff --git a/src/Change_Ticket.php b/src/Change_Ticket.php index 2920ed246c8..56031d12f55 100644 --- a/src/Change_Ticket.php +++ b/src/Change_Ticket.php @@ -206,6 +206,7 @@ public static function processMassiveActionsForOneItemtype( * Show tickets for a change * * @param Change $change + * @return void **/ public static function showForChange(Change $change) { @@ -213,7 +214,7 @@ public static function showForChange(Change $change) $ID = $change->getField('id'); if (!$change->can($ID, READ)) { - return false; + return; } $canedit = $change->canEdit($ID); @@ -307,6 +308,7 @@ public static function showForChange(Change $change) * Show changes for a ticket * * @param Ticket $ticket object + * @return void **/ public static function showForTicket(Ticket $ticket) { @@ -314,7 +316,7 @@ public static function showForTicket(Ticket $ticket) $ID = $ticket->getField('id'); if (!$ticket->can($ID, READ)) { - return false; + return; } $canedit = $ticket->canEdit($ID); diff --git a/src/CommonITILRecurrent.php b/src/CommonITILRecurrent.php index e321b7c244b..a652c1d61a3 100644 --- a/src/CommonITILRecurrent.php +++ b/src/CommonITILRecurrent.php @@ -44,6 +44,7 @@ */ abstract class CommonITILRecurrent extends CommonDropdown { + /** @use Clonable */ use Clonable; /** diff --git a/src/ProblemTask.php b/src/ProblemTask.php index 6735fbaba25..6235067511a 100644 --- a/src/ProblemTask.php +++ b/src/ProblemTask.php @@ -43,7 +43,7 @@ public static function getTypeName($nb = 0) /** * Populate the planning with planned problem tasks * - * @param $options array of possible options: + * @param array $options array of possible options: * - who ID of the user (0 = undefined) * - whogroup ID of the group of users (0 = undefined) * - begin Date @@ -75,7 +75,7 @@ public static function displayPlanningItem(array $val, $who, $type = "", $comple /** * Populate the planning with not planned problem tasks * - * @param $options array of possible options: + * @param array $options array of possible options: * - who ID of the user (0 = undefined) * - whogroup ID of the group of users (0 = undefined) * - begin Date diff --git a/src/Problem_Ticket.php b/src/Problem_Ticket.php index d666b61d3c2..7742c37b34b 100644 --- a/src/Problem_Ticket.php +++ b/src/Problem_Ticket.php @@ -191,13 +191,14 @@ public static function processMassiveActionsForOneItemtype( * Show tickets for a problem * * @param Problem $problem + * @return void **/ public static function showForProblem(Problem $problem) { $ID = $problem->getField('id'); if (!static::canView() || !$problem->can($ID, READ)) { - return false; + return; } $canedit = $problem->canEdit($ID); @@ -266,6 +267,7 @@ public static function showForProblem(Problem $problem) * Show problems for a ticket * * @param Ticket $ticket object + * @return void **/ public static function showForTicket(Ticket $ticket) { @@ -273,7 +275,7 @@ public static function showForTicket(Ticket $ticket) $ID = $ticket->getField('id'); if (!static::canView() || !$ticket->can($ID, READ)) { - return false; + return; } $canedit = $ticket->can($ID, UPDATE); diff --git a/src/TicketTask.php b/src/TicketTask.php index 353df8c787a..6691d62fbc7 100644 --- a/src/TicketTask.php +++ b/src/TicketTask.php @@ -43,7 +43,7 @@ public static function getTypeName($nb = 0) /** * Populate the planning with planned ticket tasks * - * @param $options array of possible options: + * @param array $options array of possible options: * - who ID of the user (0 = undefined) * - whogroup ID of the group of users (0 = undefined) * - begin Date @@ -60,7 +60,7 @@ public static function populatePlanning($options = []): array /** * Populate the planning with planned ticket tasks * - * @param $options array of possible options: + * @param array $options array of possible options: * - who ID of the user (0 = undefined) * - whogroup ID of the group of users (0 = undefined) * - begin Date