New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2958 #2961

Merged
merged 2 commits into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@trasher
Member

trasher commented Oct 12, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2958

@trasher trasher requested a review from orthagh Oct 12, 2017

@trasher trasher requested a review from yllen Oct 12, 2017

@yllen

This comment has been minimized.

Show comment
Hide comment
@yllen

yllen Oct 12, 2017

Contributor

OK for Historical tab.
But you delete link to go to saved search, you must stay it.
My problem was for List link not saved search name

Contributor

yllen commented Oct 12, 2017

OK for Historical tab.
But you delete link to go to saved search, you must stay it.
My problem was for List link not saved search name

@trasher

This comment has been minimized.

Show comment
Hide comment
@trasher

trasher Oct 12, 2017

Member

There is no alerts lists; this link was provided as a link to te saved search when you came from the saved search list. The "List..." link was a default I did not know we can remove initially; and the link to the saved search is already present in the form.

Member

trasher commented Oct 12, 2017

There is no alerts lists; this link was provided as a link to te saved search when you came from the saved search list. The "List..." link was a default I did not know we can remove initially; and the link to the saved search is already present in the form.

@yllen

This comment has been minimized.

Show comment
Hide comment
@yllen

yllen Oct 12, 2017

Contributor

I have the problem with this link List only after create a new alert.
Question: why in saved search i only have public search? The notification alert can be for private one.
And how can i modify an existing one? when i click on the name the bookmark is loaded

Contributor

yllen commented Oct 12, 2017

I have the problem with this link List only after create a new alert.
Question: why in saved search i only have public search? The notification alert can be for private one.
And how can i modify an existing one? when i click on the name the bookmark is loaded

@yllen

This comment has been minimized.

Show comment
Hide comment
@yllen

yllen Oct 12, 2017

Contributor

Another point to alert.
If i have only 1 item i can't create 2 alerts (i have button but nothing done when i add, even message).
I you can create disable alert you can create several.

Contributor

yllen commented Oct 12, 2017

Another point to alert.
If i have only 1 item i can't create 2 alerts (i have button but nothing done when i add, even message).
I you can create disable alert you can create several.

@trasher

This comment has been minimized.

Show comment
Hide comment
@trasher

trasher Oct 12, 2017

Member

why in saved search i only have public search?

In saved search management interface you mean? I've just tested with two saved searches created from computers, on private and one public; can see both (with default glpi account).
Modification of private search is the same than public ones; from the management interface. The slide panel does not provide that.

i have button but nothing done

You mean you even do not have the alert form? I've tested on previously created searches, I was able to create several alerts on each one...

Don't know what the problem is exactly right now; but I wonder if both problems does not have only one cause. Did you try relogin? Which profiles did you use?

Member

trasher commented Oct 12, 2017

why in saved search i only have public search?

In saved search management interface you mean? I've just tested with two saved searches created from computers, on private and one public; can see both (with default glpi account).
Modification of private search is the same than public ones; from the management interface. The slide panel does not provide that.

i have button but nothing done

You mean you even do not have the alert form? I've tested on previously created searches, I was able to create several alerts on each one...

Don't know what the problem is exactly right now; but I wonder if both problems does not have only one cause. Did you try relogin? Which profiles did you use?

@yllen

This comment has been minimized.

Show comment
Hide comment
@yllen

yllen Oct 13, 2017

Contributor

bookmark
In Tools > saved search i only see public search
In star to load bookmarks i see public and private searches.
So i can't modify private because there are not in list

Contributor

yllen commented Oct 13, 2017

bookmark
In Tools > saved search i only see public search
In star to load bookmarks i see public and private searches.
So i can't modify private because there are not in list

@yllen

This comment has been minimized.

Show comment
Hide comment
@yllen

yllen Oct 13, 2017

Contributor

You mean you even do not have the alert form? I've tested on previously created searches, I was able to create several alerts on each one...

Example: i have only 1 phone in item Phone
I create a bookmark for this phone.
I create an alert for this bookmark.
I want to create a second one. I have the button Add a new alert. I click on it, have the form and complete it. On click on Save button, form is reload empty

Contributor

yllen commented Oct 13, 2017

You mean you even do not have the alert form? I've tested on previously created searches, I was able to create several alerts on each one...

Example: i have only 1 phone in item Phone
I create a bookmark for this phone.
I create an alert for this bookmark.
I want to create a second one. I have the button Add a new alert. I click on it, have the form and complete it. On click on Save button, form is reload empty

@yllen

This comment has been minimized.

Show comment
Hide comment
@yllen

yllen Oct 13, 2017

Contributor

Test done this day and issue is the same. I used Super-Admin profil

Contributor

yllen commented Oct 13, 2017

Test done this day and issue is the same. I used Super-Admin profil

@trasher

This comment has been minimized.

Show comment
Hide comment
@trasher

trasher Oct 13, 2017

Member

I still cannot reproduce :/ Tested on a phone asset as well; and I can see private searches in the list; and also create as many alerts as I want.

For the list problem, could you please send the query that is played in the management interface?

Member

trasher commented Oct 13, 2017

I still cannot reproduce :/ Tested on a phone asset as well; and I can see private searches in the list; and also create as many alerts as I want.

For the list problem, could you please send the query that is played in the management interface?

@trasher

This comment has been minimized.

Show comment
Hide comment
@trasher

trasher Oct 13, 2017

Member

OK, got it for private searches...
All private searches are in the root entity; and not recursive. In the panel, we take care of that, looking for entities restrictions only for public ones.

So the problem only appears when you use any entity but the root.

Member

trasher commented Oct 13, 2017

OK, got it for private searches...
All private searches are in the root entity; and not recursive. In the panel, we take care of that, looking for entities restrictions only for public ones.

So the problem only appears when you use any entity but the root.

@yllen

This comment has been minimized.

Show comment
Hide comment
@yllen

yllen Oct 13, 2017

Contributor

I think i have understand the issue.
In search engine you only have searches for this entity or recursive one.
With bookmarks of my settings you have public bookmarks for this entity and private bookmark for all entities.
So if you have define a bookmark from root entity no recursive and private, you can load it from a sub-entity.

Contributor

yllen commented Oct 13, 2017

I think i have understand the issue.
In search engine you only have searches for this entity or recursive one.
With bookmarks of my settings you have public bookmarks for this entity and private bookmark for all entities.
So if you have define a bookmark from root entity no recursive and private, you can load it from a sub-entity.

@trasher

This comment has been minimized.

Show comment
Hide comment
@trasher

trasher Oct 13, 2017

Member

I do not know why is_recursive is set to 0; it always been. On private searches; this does not really makes sense. I propose to change is_recusrive to 1 for all private searches.
Could you try if that fixes your issues?

Member

trasher commented Oct 13, 2017

I do not know why is_recursive is set to 0; it always been. On private searches; this does not really makes sense. I propose to change is_recusrive to 1 for all private searches.
Could you try if that fixes your issues?

@yllen

This comment has been minimized.

Show comment
Hide comment
@yllen

yllen Oct 13, 2017

Contributor

I can need to do a specific search for a sub-entity.
For me in bookmarks list of my settings i must have only private search for this entity

Contributor

yllen commented Oct 13, 2017

I can need to do a specific search for a sub-entity.
For me in bookmarks list of my settings i must have only private search for this entity

@trasher

This comment has been minimized.

Show comment
Hide comment
@trasher

trasher Oct 13, 2017

Member

So, this is related to #2882

Member

trasher commented Oct 13, 2017

So, this is related to #2882

@trasher trasher merged commit 25326d7 into glpi-project:9.2/bugfixes Oct 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@trasher trasher deleted the trasher:fix-2958 branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment