Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthernetProtocolDecoder: correctly display old-style 802.3 framing without EtherType field in protocol analyzer view #401

Closed
azonenberg opened this issue Apr 2, 2021 · 0 comments
Closed

EthernetProtocolDecoder: correctly display old-style 802.3 framing without EtherType field in protocol analyzer view #401

azonenberg opened this issue Apr 2, 2021 · 0 comments
Labels
filter Filter graph blocks
Milestone
v0.1

Comments

@azonenberg
Copy link
Collaborator

Currently the frame lengths are mis-parsed as ethertypes and displayed in red as raw hex values.
@azonenberg azonenberg added the filter Filter graph blocks label Apr 2, 2021
@azonenberg azonenberg added this to the v0.1 milestone Apr 24, 2021
azonenberg added a commit that referenced this issue Mar 11, 2022
@azonenberg
Added explit "use display locale" vs "use serialization locale" argum…
9d88ad7 
…ent to Unit string conversions. FilterParameter now uses correct locale for display while keeping "C" locale for serialization. Fixes #401.
dannas pushed a commit to dannas/scopehal that referenced this issue Jul 1, 2022
@azonenberg @dannas
Added explit "use display locale" vs "use serialization locale" argum…
e62b674 
…ent to Unit string conversions. FilterParameter now uses correct locale for display while keeping "C" locale for serialization. Fixes glscopeclient#401.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
filter Filter graph blocks
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@azonenberg