Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate code related to QThread to make sure we don't import Qt in glue-jupyter #2012

Merged
merged 4 commits into from May 23, 2019

Conversation

Projects
None yet
1 participant
@astrofrog
Copy link
Member

commented May 23, 2019

Before this PR, if Qt was installed it could end up getting imported and used for QThread even if using a non-Qt frontend. This PR cleanly separates the part of the histogram and profile layer artist that depends on QThread into Qt-specific layer artist sub-classes.

astrofrog added some commits May 23, 2019

Moved parts of layer artist for histogram and profile viewer that rel…
…y on QThread to a Qt-specific class to make sure this is only used when inside a Qt viewer, not just contingent on whether Qt is installed.

@astrofrog astrofrog added this to the v0.15.0 milestone May 23, 2019

@astrofrog astrofrog merged commit 4eced4b into glue-viz:master May 23, 2019

10 of 11 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: py27_pyqt510 Your tests passed on CircleCI!
Details
ci/circleci: py35_pyqt510 Your tests passed on CircleCI!
Details
ci/circleci: py35_pyqt57 Your tests passed on CircleCI!
Details
ci/circleci: py35_pyqt58 Your tests passed on CircleCI!
Details
ci/circleci: py35_pyqt59 Your tests passed on CircleCI!
Details
ci/circleci: py36_pyqt511 Your tests passed on CircleCI!
Details
ci/circleci: py36_pyqt512 Your tests passed on CircleCI!
Details
ci/circleci: py36_pyside511 Your tests passed on CircleCI!
Details
ci/circleci: py36_pyside512 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.