Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simply resolution of Attach artifacts on JVM #323

Closed
abhinayagarwal opened this issue May 27, 2021 · 0 comments · Fixed by #324
Closed

Simply resolution of Attach artifacts on JVM #323

abhinayagarwal opened this issue May 27, 2021 · 0 comments · Fixed by #324
Assignees

Comments

@abhinayagarwal
Copy link
Collaborator

javafx:run goal from the javafx-maven-plugin is used to run an application on the desktop. While this works for most cases, there is an overhead for the user where they need to define the correct Attach dependencies for the project while running on desktop.

For example, if we check the HelloGluon sample, a profile needs to be created for Desktop and all Attach dependencies with classifier as desktop needs to be added to the profile. Where as the same is not required for targets like Android and iOS.

To overcome this, my proposal is to create a new goal in the client plugin which can take care of correct Attach dependencies and supersedes the call to javafx:run.

The perfect candidate for this new goal would be client:run, however, since we already have the goal to run native image. Therefore, my proposal also includes to rename the existing client:run goal to client:nativerun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant