Fix word splitting logic #522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
section:host split would work well in case of ipv4, however with ipv6 the current logic failed since ipv6 has : as separator which conflicted with section:host separator. For example with ipv6 the lv would look like [lv1:fe80::6dc9:8205:9bd6:fb40] which confused gdeploy. Now we handle this by splitting max 1 word.
Since ipv6 is colon separated, ConfigParser does not handle them gracefully, the first part is considered as a key than the complete string being handled as an address. This change adds two functions to handle the config files gracefully when ipv6 is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
section:host split would work well in case of ipv4, however with
ipv6 the current logic failed since ipv6 has : as separator which
conflicted with section:host separator. For example with ipv6 the
lv would look like [lv1:fe80::6dc9:8205:9bd6:fb40] which confused
gdeploy. Now we handle this by splitting max 1 word.