New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] provide sub-directory mount option in fuse, for a given volume #175

Closed
amarts opened this Issue Apr 18, 2017 · 35 comments

Comments

@amarts
Member

amarts commented Apr 18, 2017

Currently, glusterfs's fuse mount doesn't provide option to mount subdirectory like NFS mounts. Providing such option would be good to reduce the number of volumes created in glusterfs.

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts Apr 18, 2017

Member

Feedback welcome on : https://review.gluster.org/17075
Two options to mount:

$ mount -t glusterfs local:fop-metrics -osubdir-mount=mountdir /mnt/fuse

$ glusterfs --volfile-server=local --volfile-id=fop-metrics --subdir-mount=mountdir /mnt/fuse

Member

amarts commented Apr 18, 2017

Feedback welcome on : https://review.gluster.org/17075
Two options to mount:

$ mount -t glusterfs local:fop-metrics -osubdir-mount=mountdir /mnt/fuse

$ glusterfs --volfile-server=local --volfile-id=fop-metrics --subdir-mount=mountdir /mnt/fuse

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts Apr 20, 2017

Member

@jdarcy i heard you had sent a patch for something similar long back. I didn't find it in 90days backlog, I am fine to review that, or consider this, which ever is works good for you. Lets see if we can get this feature in.

@csabahenk

Member

amarts commented Apr 20, 2017

@jdarcy i heard you had sent a patch for something similar long back. I didn't find it in 90days backlog, I am fine to review that, or consider this, which ever is works good for you. Lets see if we can get this feature in.

@csabahenk

@atinmu

This comment has been minimized.

Show comment
Hide comment
@atinmu

atinmu Apr 20, 2017

Contributor

@amarts https://review.gluster.org/#/c/13659/ though it's abandoned now.

Contributor

atinmu commented Apr 20, 2017

@amarts https://review.gluster.org/#/c/13659/ though it's abandoned now.

@itisravi

This comment has been minimized.

Show comment
Hide comment
@itisravi

itisravi Apr 20, 2017

Contributor

@amarts Not sure if your approach is similar, but there is already a patch for this (with a -2 though): https://review.gluster.org/#/c/10186/

Contributor

itisravi commented Apr 20, 2017

@amarts Not sure if your approach is similar, but there is already a patch for this (with a -2 though): https://review.gluster.org/#/c/10186/

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts Apr 20, 2017

Member

Thanks for all these pointers. Yes, I am aware of client side approach being not good enough.

But i still believe this is a good enough solution if on the client machines admin has not given access to people to mount.

I like the tenant approach @jdarcy did. Will need further discussion on this.

Member

amarts commented Apr 20, 2017

Thanks for all these pointers. Yes, I am aware of client side approach being not good enough.

But i still believe this is a good enough solution if on the client machines admin has not given access to people to mount.

I like the tenant approach @jdarcy did. Will need further discussion on this.

@csabahenk

This comment has been minimized.

Show comment
Hide comment
@csabahenk

csabahenk Apr 20, 2017

Member

With respect to prior art -- @pranithk mentions here: https://bugzilla.redhat.com/892808#c31 some related work by Facebook. I wonder if anyone knows anything about that?

Member

csabahenk commented Apr 20, 2017

With respect to prior art -- @pranithk mentions here: https://bugzilla.redhat.com/892808#c31 some related work by Facebook. I wonder if anyone knows anything about that?

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts Apr 20, 2017

Member

Can we list down the basic necessity of the feature?

  1. Inode tables: Should they be different?

    • What happens for locks, quota, etc etc (ie, the stuff kept in inode-ctx for synchronized access).
    • If they are not different, should the logic be on server-protocol?
    • If no, would gf-proxy approach good enough?
    • Or do we go with fuse inode table change approach ?
      • How will client be properly authenticated?
      • Should we consider FreeIPA/AD integration?
  2. What are the access-control (like auth.allow etc) we need to provide for this subdirectory being exported?

  3. Is it good enough to support just the toplevel directory, or people want more depth in general?

Member

amarts commented Apr 20, 2017

Can we list down the basic necessity of the feature?

  1. Inode tables: Should they be different?

    • What happens for locks, quota, etc etc (ie, the stuff kept in inode-ctx for synchronized access).
    • If they are not different, should the logic be on server-protocol?
    • If no, would gf-proxy approach good enough?
    • Or do we go with fuse inode table change approach ?
      • How will client be properly authenticated?
      • Should we consider FreeIPA/AD integration?
  2. What are the access-control (like auth.allow etc) we need to provide for this subdirectory being exported?

  3. Is it good enough to support just the toplevel directory, or people want more depth in general?

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts Apr 20, 2017

Member

@pranithk @csabahenk @jdarcy @vbellur lets list down the requirements properly IMO, so that we can finalize the approach quickly.

Member

amarts commented Apr 20, 2017

@pranithk @csabahenk @jdarcy @vbellur lets list down the requirements properly IMO, so that we can finalize the approach quickly.

@nixpanic

This comment has been minimized.

Show comment
Hide comment
@nixpanic

nixpanic May 1, 2017

Member

The requirements and limitations should be documented in the subdirectory-mounts.md

Member

nixpanic commented May 1, 2017

The requirements and limitations should be documented in the subdirectory-mounts.md

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts May 2, 2017

Member

@nixpanic thanks for the link.

With https://review.gluster.org/17141 most of it is solved, other than providing different auth.allow/auth.reject string handling. @kshlm

I would keep that as an separate effort and allow everyone to review the above patch. @pranithk, @jdarcy

Member

amarts commented May 2, 2017

@nixpanic thanks for the link.

With https://review.gluster.org/17141 most of it is solved, other than providing different auth.allow/auth.reject string handling. @kshlm

I would keep that as an separate effort and allow everyone to review the above patch. @pranithk, @jdarcy

@nixpanic

This comment has been minimized.

Show comment
Hide comment
@nixpanic

nixpanic May 2, 2017

Member

As long as auth.allow and auth,reject (the volume wide options) are also enforced for the subdir mounts, adding an improvement for those later should be fine imho.

Member

nixpanic commented May 2, 2017

As long as auth.allow and auth,reject (the volume wide options) are also enforced for the subdir mounts, adding an improvement for those later should be fine imho.

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts May 2, 2017

Member

@nixpanic they are. With current patch, the handshake will be successful if auth.allow and auth.reject modules are properly handled. Subdir mount code comes to effect only at the last point where we were doing lookup() (after all successful call).

Member

amarts commented May 2, 2017

@nixpanic they are. With current patch, the handshake will be successful if auth.allow and auth.reject modules are properly handled. Subdir mount code comes to effect only at the last point where we were doing lookup() (after all successful call).

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant May 29, 2017

Collaborator

A patch https://review.gluster.org/17075 has been posted that references this issue.
Commit message: fuse-bridge: cleanup first_lookup()

Collaborator

gluster-ant commented May 29, 2017

A patch https://review.gluster.org/17075 has been posted that references this issue.
Commit message: fuse-bridge: cleanup first_lookup()

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant May 30, 2017

Collaborator

A patch https://review.gluster.org/17075 has been posted that references this issue.
Commit message: fuse-bridge: cleanup first_lookup()

Collaborator

gluster-ant commented May 30, 2017

A patch https://review.gluster.org/17075 has been posted that references this issue.
Commit message: fuse-bridge: cleanup first_lookup()

mscherer pushed a commit that referenced this issue May 30, 2017

fuse-bridge: cleanup first_lookup()
use syncop_lookup instead of synchronising stack_wind/unwind again.

Updates #175

Change-Id: Iad4a181d8601235a999039979bfb7ec688675520
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17075
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Jun 12, 2017

Collaborator

A patch https://review.gluster.org/17510 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Jun 12, 2017

A patch https://review.gluster.org/17510 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

mscherer pushed a commit that referenced this issue Jun 13, 2017

glusterfsd: allow subdir mount
Changes:

1. Take subdir mount option in client (mount.gluster / glusterfsd)
2. Pass the subdir mount to server-handshake (from client-handshake)
3. Handle subdir-mount dir's lookup in server-first-lookup and handle
   all fops resolution accordingly with proper gfid of subdir

How to use the feature:

`# mount -t glusterfs $hostname:/$volname/$subdir /$mount_point`
Or
`# mount -t glusterfs $hostname:/$volname -osubdir_mount=$subdir /$mount_point`

TODO:

This change by itself is working. But more granular control can
be given to subdir mount in terms of 'auth.allow', which can be
extended in glusterd and in xlators/protocol/server/auth/*

Updates #175

Change-Id: I7ea57f76ddbe6c3862cfe02e13f89e8a39719e11
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17510
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Jul 20, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Jul 20, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts Jul 20, 2017

Member

What is pending is, how will we handle the authentication options for this at each subdir level?

I propose to keep the current option and extending it to handle new feature with proper backward compatibility.

Currently, the option auth.allow (and auth.reject) are of the type GF_OPTION_TYPE_INTERNET_ADDRESS_LIST. Which expects valid internet addresses with comma separation.

For example the current option looks likes this:

option auth.addr.brick-name.allow * OR option auth.addr.brick-name.allow "192.168.*.* ,10.10.*.*".

In future, it may look like:

option auth.addr.brick-name.allow "10.0.1.13;192.168.1.* =/subdir1;192.168.10.* ,192.168.11.104 =/subdir2"

so each entries will be separated by ';'. And in each entry, first part (" =") is address list and second part is directory. If directory is empty, its assumed as '/'. (Handles the backward compatibility). And if there is no entry for a $subdir here, that $subdir won't be mountable.

(The above format is handled properly already at [2] in addr.c, the pending thing is to handle the option properly in options.c's validate).

[1] - #175
[2] - https://review.gluster.org/17141

If everyone agrees to this, I guess we can pull it off before absolute feature freeze date for 3.12 branch.

Let me know the feedback.

NOTE: I thought of using ':' (colon) as field separator between addr_list and subdir entry, but with IPv6 ':' is valid character in string. Hence using ' ='.

@vbellur @jdarcy @ShyamsundarR @atinmu @kshlm @nixpanic @kalebskeithley @csabahenk @JohnStrunk

Member

amarts commented Jul 20, 2017

What is pending is, how will we handle the authentication options for this at each subdir level?

I propose to keep the current option and extending it to handle new feature with proper backward compatibility.

Currently, the option auth.allow (and auth.reject) are of the type GF_OPTION_TYPE_INTERNET_ADDRESS_LIST. Which expects valid internet addresses with comma separation.

For example the current option looks likes this:

option auth.addr.brick-name.allow * OR option auth.addr.brick-name.allow "192.168.*.* ,10.10.*.*".

In future, it may look like:

option auth.addr.brick-name.allow "10.0.1.13;192.168.1.* =/subdir1;192.168.10.* ,192.168.11.104 =/subdir2"

so each entries will be separated by ';'. And in each entry, first part (" =") is address list and second part is directory. If directory is empty, its assumed as '/'. (Handles the backward compatibility). And if there is no entry for a $subdir here, that $subdir won't be mountable.

(The above format is handled properly already at [2] in addr.c, the pending thing is to handle the option properly in options.c's validate).

[1] - #175
[2] - https://review.gluster.org/17141

If everyone agrees to this, I guess we can pull it off before absolute feature freeze date for 3.12 branch.

Let me know the feedback.

NOTE: I thought of using ':' (colon) as field separator between addr_list and subdir entry, but with IPv6 ':' is valid character in string. Hence using ' ='.

@vbellur @jdarcy @ShyamsundarR @atinmu @kshlm @nixpanic @kalebskeithley @csabahenk @JohnStrunk

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Jul 20, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Jul 20, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts Jul 23, 2017

Member

@ShyamsundarR can we get this in for 3.12 branch?

Member

amarts commented Jul 23, 2017

@ShyamsundarR can we get this in for 3.12 branch?

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Jul 24, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Jul 24, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Jul 25, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Jul 25, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Jul 26, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Jul 26, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@ShyamsundarR ShyamsundarR removed this from Release 4.0 in Releases Jul 28, 2017

@ShyamsundarR

This comment has been minimized.

Show comment
Hide comment
@ShyamsundarR

ShyamsundarR Jul 31, 2017

Contributor

There is a lot of momentum around this patch, we can wait till Aug 2nd 2017, to take a backport of the same for the 3.12 release. Holding it in the 3.12 release scope till then.

Contributor

ShyamsundarR commented Jul 31, 2017

There is a lot of momentum around this patch, we can wait till Aug 2nd 2017, to take a backport of the same for the 3.12 release. Holding it in the 3.12 release scope till then.

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Aug 2, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Aug 2, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

mscherer pushed a commit that referenced this issue Aug 2, 2017

glusterfsd: allow subdir mount
Changes:

1. Take subdir mount option in client (mount.gluster / glusterfsd)
2. Pass the subdir mount to server-handshake (from client-handshake)
3. Handle subdir-mount dir's lookup in server-first-lookup and handle
   all fops resolution accordingly with proper gfid of subdir
4. Change the auth/addr module to handle the multiple subdir entries
   in option, and valid parsing.

How to use the feature:

`# mount -t glusterfs $hostname:/$volname/$subdir /$mount_point`
Or
`# mount -t glusterfs $hostname:/$volname -osubdir_mount=$subdir /$mount_point`

Option can be set like:

`# gluster volume set <volname> auth.allow "/subdir1(192.168.1.*),/(192.168.10.*),/subdir2(192.168.8.*)"`

Updates #175

Change-Id: I7ea57f76ddbe6c3862cfe02e13f89e8a39719e11
Signed-off-by: Amar Tumballi <amarts@redhat.com>

mscherer pushed a commit that referenced this issue Aug 2, 2017

glusterfsd: allow subdir mount
Changes:

1. Take subdir mount option in client (mount.gluster / glusterfsd)
2. Pass the subdir mount to server-handshake (from client-handshake)
3. Handle subdir-mount dir's lookup in server-first-lookup and handle
   all fops resolution accordingly with proper gfid of subdir
4. Change the auth/addr module to handle the multiple subdir entries
   in option, and valid parsing.

How to use the feature:

`# mount -t glusterfs $hostname:/$volname/$subdir /$mount_point`
Or
`# mount -t glusterfs $hostname:/$volname -osubdir_mount=$subdir /$mount_point`

Option can be set like:

`# gluster volume set <volname> auth.allow "/subdir1(192.168.1.*),/(192.168.10.*),/subdir2(192.168.8.*)"`

Updates #175

Change-Id: I7ea57f76ddbe6c3862cfe02e13f89e8a39719e11
Signed-off-by: Amar Tumballi <amarts@redhat.com>
@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Aug 3, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Aug 3, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Aug 3, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Aug 3, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Aug 3, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Aug 3, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Aug 3, 2017

Collaborator

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Aug 3, 2017

A patch https://review.gluster.org/17141 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Aug 3, 2017

Collaborator

A patch https://review.gluster.org/17968 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

Collaborator

gluster-ant commented Aug 3, 2017

A patch https://review.gluster.org/17968 has been posted that references this issue.
Commit message: glusterfsd: allow subdir mount

mscherer pushed a commit that referenced this issue Aug 4, 2017

glusterfsd: allow subdir mount
Changes:

1. Take subdir mount option in client (mount.gluster / glusterfsd)
2. Pass the subdir mount to server-handshake (from client-handshake)
3. Handle subdir-mount dir's lookup in server-first-lookup and handle
   all fops resolution accordingly with proper gfid of subdir
4. Change the auth/addr module to handle the multiple subdir entries
   in option, and valid parsing.

How to use the feature:

`# mount -t glusterfs $hostname:/$volname/$subdir /$mount_point`
Or
`# mount -t glusterfs $hostname:/$volname -osubdir_mount=$subdir /$mount_point`

Option can be set like:

`# gluster volume set <volname> auth.allow "/subdir1(192.168.1.*),/(192.168.10.*),/subdir2(192.168.8.*)"`

Updates #175

Change-Id: I7ea57f76ddbe6c3862cfe02e13f89e8a39719e11
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17141
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>

mscherer pushed a commit that referenced this issue Aug 4, 2017

glusterfsd: allow subdir mount
Changes:

1. Take subdir mount option in client (mount.gluster / glusterfsd)
2. Pass the subdir mount to server-handshake (from client-handshake)
3. Handle subdir-mount dir's lookup in server-first-lookup and handle
   all fops resolution accordingly with proper gfid of subdir
4. Change the auth/addr module to handle the multiple subdir entries
   in option, and valid parsing.

How to use the feature:

`# mount -t glusterfs $hostname:/$volname/$subdir /$mount_point`
Or
`# mount -t glusterfs $hostname:/$volname -osubdir_mount=$subdir /$mount_point`

Option can be set like:

`# gluster volume set <volname> auth.allow "/subdir1(192.168.1.*),/(192.168.10.*),/subdir2(192.168.8.*)"`

Updates #175

> Reviewed-At: https://review.gluster.org/17141/

Change-Id: I7ea57f76ddbe6c3862cfe02e13f89e8a39719e11
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17968
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
@ShyamsundarR

This comment has been minimized.

Show comment
Hide comment
@ShyamsundarR

ShyamsundarR Aug 29, 2017

Contributor

@amarts as most of the code is in release-3.12, should this issue be closed? Or, are there pending TODOs that are tracked via this issue? (if so request you to just list them here)

Contributor

ShyamsundarR commented Aug 29, 2017

@amarts as most of the code is in release-3.12, should this issue be closed? Or, are there pending TODOs that are tracked via this issue? (if so request you to just list them here)

@amarts

This comment has been minimized.

Show comment
Hide comment
@amarts

amarts Sep 22, 2017

Member

Sorry missed the above comments. I would like to close this, and treat any further issues as bugs. The feature itself can be said as completed for now.

Member

amarts commented Sep 22, 2017

Sorry missed the above comments. I would like to close this, and treat any further issues as bugs. The feature itself can be said as completed for now.

@amarts amarts closed this Sep 22, 2017

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Oct 11, 2017

Collaborator

A patch https://review.gluster.org/18489 has been posted that references this issue.
Commit message: protocol-auth: use the proper validation method

Collaborator

gluster-ant commented Oct 11, 2017

A patch https://review.gluster.org/18489 has been posted that references this issue.
Commit message: protocol-auth: use the proper validation method

mscherer pushed a commit that referenced this issue Oct 12, 2017

protocol-auth: use the proper validation method
Currently, server protocol's init and glusterd's option
validation methods are different, causing an issue. They
should be same for having consistent behavior

Updates #175

Change-Id: Ibbf9a18c7192b2d77f9b7675ae7da9b8d2fe5de4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Oct 22, 2017

Collaborator

A patch https://review.gluster.org/18550 has been posted that references this issue.
Commit message: protocol/client: handle the subdir handshake properly for add-brick

Collaborator

gluster-ant commented Oct 22, 2017

A patch https://review.gluster.org/18550 has been posted that references this issue.
Commit message: protocol/client: handle the subdir handshake properly for add-brick

@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Oct 22, 2017

Collaborator

A patch https://review.gluster.org/18550 has been posted that references this issue.
Commit message: protocol/client: handle the subdir handshake properly for add-brick

Collaborator

gluster-ant commented Oct 22, 2017

A patch https://review.gluster.org/18550 has been posted that references this issue.
Commit message: protocol/client: handle the subdir handshake properly for add-brick

amarts added a commit to amarts/glusterfs that referenced this issue Oct 31, 2017

fuse-bridge: cleanup first_lookup()
use syncop_lookup instead of synchronising stack_wind/unwind again.

Updates gluster#175

Change-Id: Iad4a181d8601235a999039979bfb7ec688675520
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17075
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>

amarts added a commit to amarts/glusterfs that referenced this issue Oct 31, 2017

glusterfsd: allow subdir mount
Changes:

1. Take subdir mount option in client (mount.gluster / glusterfsd)
2. Pass the subdir mount to server-handshake (from client-handshake)
3. Handle subdir-mount dir's lookup in server-first-lookup and handle
   all fops resolution accordingly with proper gfid of subdir
4. Change the auth/addr module to handle the multiple subdir entries
   in option, and valid parsing.

How to use the feature:

`# mount -t glusterfs $hostname:/$volname/$subdir /$mount_point`
Or
`# mount -t glusterfs $hostname:/$volname -osubdir_mount=$subdir /$mount_point`

Option can be set like:

`# gluster volume set <volname> auth.allow "/subdir1(192.168.1.*),/(192.168.10.*),/subdir2(192.168.8.*)"`

Updates gluster#175

Change-Id: I7ea57f76ddbe6c3862cfe02e13f89e8a39719e11
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Reviewed-on: https://review.gluster.org/17141
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>

amarts added a commit to amarts/glusterfs that referenced this issue Oct 31, 2017

protocol-auth: use the proper validation method
Currently, server protocol's init and glusterd's option
validation methods are different, causing an issue. They
should be same for having consistent behavior

Updates gluster#175

Change-Id: Ibbf9a18c7192b2d77f9b7675ae7da9b8d2fe5de4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
@gluster-ant

This comment has been minimized.

Show comment
Hide comment
@gluster-ant

gluster-ant Feb 19, 2018

Collaborator

A patch https://review.gluster.org/18645 has been posted that references this issue.
Commit message: hooks: add a script to stat the subdirs in add-brick

Collaborator

gluster-ant commented Feb 19, 2018

A patch https://review.gluster.org/18645 has been posted that references this issue.
Commit message: hooks: add a script to stat the subdirs in add-brick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment