Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-threaded fuse readers #412

Closed
KritikaDhananjay opened this issue Feb 28, 2018 · 3 comments
Closed

Add support for multi-threaded fuse readers #412

KritikaDhananjay opened this issue Feb 28, 2018 · 3 comments
Assignees

Comments

@KritikaDhananjay
Copy link
Contributor

When we (Manoj Pillai, Raghavendra G and I) were working on enhancing gluster read/write performance on NVMe backend, at one point it was observed that the fuse reader thread hit ~97% utilization even with client-io-threads enabled. At this point, single-threaded fuse reader became the bottleneck. The only option left was to scale the number of fuse threads. With this, we saw 8K iops improvement with 4 reader threads. Refer to https://goo.gl/AubdwP and/or https://goo.gl/6VbqRA for more information on actual tests performed and the results.

@KritikaDhananjay KritikaDhananjay self-assigned this Feb 28, 2018
@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/19226 has been posted that references this issue.
Commit message: mount/fuse: Add support for multi-threaded fuse readers

@KritikaDhananjay
Copy link
Contributor Author

@manojtpillai @raghavendrahg ^^

@ShyamsundarR ShyamsundarR added this to the Release 4.1 (LTM) milestone Mar 27, 2018
@ShyamsundarR ShyamsundarR added this to Release 4.1 in Releases Mar 27, 2018
gluster-ant pushed a commit that referenced this issue Apr 2, 2018
Usage: Use 'reader-thread-count=<NUM>' as command line option to
set the thread count at the time of mounting the volume.

Next task is to make these threads auto-scale based on the load,
instead of having the user remount the volume everytime to change
the thread count.

Updates #412

Change-Id: I94aa1505e5ae6a133683d473e0e4e0edd139b76b
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/19808 has been posted that references this issue.
Commit message: mount/fuse: Set default fuse reader thread count to 1

gluster-ant pushed a commit that referenced this issue Apr 2, 2018
Updates #412

Change-Id: Ida53d8b630feabb856a3551fa888f92382ade768
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
amarts pushed a commit to amarts/glusterfs_fork that referenced this issue Sep 11, 2018
Usage: Use 'reader-thread-count=<NUM>' as command line option to
set the thread count at the time of mounting the volume.

Next task is to make these threads auto-scale based on the load,
instead of having the user remount the volume everytime to change
the thread count.

Updates gluster#412

Change-Id: I94aa1505e5ae6a133683d473e0e4e0edd139b76b
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
amarts pushed a commit to amarts/glusterfs_fork that referenced this issue Sep 11, 2018
Updates gluster#412

Change-Id: Ida53d8b630feabb856a3551fa888f92382ade768
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
guihecheng pushed a commit to guihecheng/glusterfs that referenced this issue Nov 13, 2019
     > Upstream: https://review.gluster.org/19226
     > Github issue gluster#412
     > Change-Id: I94aa1505e5ae6a133683d473e0e4e0edd139b76b

Usage: Use 'reader-thread-count=<NUM>' as command line option to
set the thread count at the time of mounting the volume.

Next task is to make these threads auto-scale based on the load,
instead of having the user remount the volume everytime to change
the thread count.

Change-Id: I94aa1505e5ae6a133683d473e0e4e0edd139b76b
BUG: 1651040
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/158514
Tested-by: RHGS Build Bot <nigelb@redhat.com>
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
csabahenk pushed a commit to csabahenk/glusterfs that referenced this issue Mar 7, 2023
     > Upstream: https://review.gluster.org/19226
     > Github issue gluster#412
     > Change-Id: I94aa1505e5ae6a133683d473e0e4e0edd139b76b

Usage: Use 'reader-thread-count=<NUM>' as command line option to
set the thread count at the time of mounting the volume.

Next task is to make these threads auto-scale based on the load,
instead of having the user remount the volume everytime to change
the thread count.

Change-Id: I94aa1505e5ae6a133683d473e0e4e0edd139b76b
BUG: 1651040
Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/158514
Tested-by: RHGS Build Bot <nigelb@redhat.com>
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants