-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-417 Migrating Authorities #926
Conversation
For full LLVM coverage report click here! |
Codecov Report
@@ Coverage Diff @@
## dev #926 +/- ##
==========================================
- Coverage 78.15% 77.69% -0.46%
==========================================
Files 68 69 +1
Lines 10896 10959 +63
==========================================
- Hits 8516 8515 -1
- Misses 2380 2444 +64
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested, otherwise looks good to me.
88f46b6
to
c683598
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few more questions.
31c45ad
to
bdb4be1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits and a comment, but looks good to me
f78723b
to
a6be852
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of proposed changes:
Already registered Authorities won’t be migrated. This means that Authorities need to be set again. This is not ideal as it will halt Task scheduling until it is manually done.
The PR includes moving the Storage to the new pallet, a runtime test asserting on the new pallet prefix, and a benchmark for the migration.
Removing the Storage Item from Creditcoin and its GenesisConfig.
Practical tips for PR review & merge: