Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a wildcard version requirement for schnorrkel dependency #933

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

nathanwhit
Copy link
Contributor

Description of proposed changes:
Glancing over our dependencies I noticed we weren't specifying a requirement, which makes it easy to accidentally get a breaking update when a new version is released.

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov merged commit a9f9103 into dev Feb 17, 2023
@atodorov atodorov deleted the dont-use-wildcard-versionspec branch February 17, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants