Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using single space between sentences #21

Merged

Conversation

Projects
None yet
2 participants
@selmanj
Copy link
Contributor

commented Feb 15, 2017

python-docstring.el will respect the value of sentence-end-double-space.

Add support for using single space between sentences
python-docstring.el will respect the value of sentence-end-double-space.
@glyph

This comment has been minimized.

Copy link
Owner

commented Feb 16, 2017

Thanks very much for your contribution!

I have slightly mixed feelings about this; on the one hand, sentence-end-double-space is an established way of configuring this behavior, and people's opinions on how it should work differ. On the other, one of the major motivations for this mode to exist is to avoid projects having diff noise when people have different configurations for re-wrapping docstrings.

If someone configured sentence-end-double-space in custom because they just happened to prefer the aesthetics, it would mean they'd be mangling docstring sentence-ends in any shared project they were to touch.

I'm not sure what the right solution is here�; perhaps a separate, explicit python-docstring-honor-sentence-end-double-space that defaults to nil?

@selmanj

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2017

That makes sense. I'll add a customize option that lets you use single spacing (defaulting to double space).

@selmanj

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2017

This is ready for review.

@glyph

This comment has been minimized.

Copy link
Owner

commented May 8, 2017

I've sat on this long enough :) thank you for your contribution.

@glyph glyph merged commit d35d2e0 into glyph:master May 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.