Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eslint-plugin-react and flow-bin to devDependencies? #70

Closed
jefftmills opened this issue Apr 22, 2021 · 4 comments
Closed

Move eslint-plugin-react and flow-bin to devDependencies? #70

jefftmills opened this issue Apr 22, 2021 · 4 comments

Comments

@jefftmills
Copy link

I have dozens of dependencies in my app that depend on these 2 modules, but react-sticky-el is the only one that has either of them in their production dependencies, so I wonder if that's a mistake. The eslint plugin seems obvious to me but I don't know anything about flow-bin.

Including flow-bin as a production dependency adds 78 MB to the node_modules footprint of this otherwise very small module, so it would be really good to remove it if it's not needed for production.

@gm0t
Copy link
Owner

gm0t commented Apr 25, 2021

@jefftmills yep, that's a very unfortunate mistake :) fixed in 2.0.8, thanks for raising it!

@gm0t gm0t closed this as completed Apr 25, 2021
@jefftmills
Copy link
Author

jefftmills commented Apr 25, 2021

Thanks for fixing it so soon. 2.0.8 isn't published to npm yet, I don't know whether that was an oversight or I just need to be more patient :)

I found this while analyzing the disk footprint of our large web app and found a couple of similar unfortunate mistakes in our own package.json, too.

@jefftmills
Copy link
Author

Hi Mikhail, can you publish this new version 2.0.8 to npm so folks can start using this new optimized distribution?

@gm0t
Copy link
Owner

gm0t commented May 11, 2021

Hi @jefftmills,
Oh... 🤦 published now, sorry for the delay I completely missed that step
I should definitely spend some time automating this step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants