Skip to content

Don't rely on being chdir'd to the project root #102

Closed
wants to merge 1 commit into from

2 participants

@MicahChalmer

While playing around with the changes made for #94 (which worked great) I noticed one quirk: Nesta relies on having the current directory be the project root. I'm guessing that may break some embedding scenarios, and there really isn't a need for it--the fix here was rather simple, and won't break cases where you have an absolute content path configured.

@gma
Owner
gma commented Mar 6, 2012

I was half way through merging this, when I realised it was going to take me a bit longer to test in action (i.e. integration style) than I've got to spare this morning. Am I right in thinking Nesta behaves itself if you set the content path relative to the current directory?

@MicahChalmer

It does seem to behave itself if I do that. I didn't test extensively, but it did find a page and output it correctly. That said, I still think it makes more sense to have it be relative to the project root, but it isn't a big deal either way.

@gma
Owner
gma commented Mar 7, 2012

Okay, thanks for reporting back.

Merging this is blocked on #103.

@gma gma closed this Oct 23, 2013
@gma
Owner
gma commented Oct 23, 2013

I've closed this because I've noticed that it's passing absolute paths to the nesta edit command. While that works fine, I'd rather it didn't do that (it doesn't feel as clean as just passing a relative path). In the absence of evidence that the current working directory is actually a problem in some scenarios, I'm therefore holding back on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.