feat: surface objectStore upload reason, attempts, and retry logs#144
Merged
Conversation
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four hardening cuts on the existing session objectStore sink, aimed at operator-grade observability rather than new feature surface:
docs/operator.mdanddocs/crd-podtracesession.mdno longer claimreportRef.objectStoreis "reserved" or that the webhook rejects it. Both have been false since the feature actually landed; new copy points at
docs/object-store-reports.md for semantics.
ReportFailureReason(InvalidURI|CredentialMissing|BucketNotFound|AccessDenied|NetworkTimeout|Unknown) onstatus.reportFailureReason, plusstatus.reportAttemptsmirroring the sidecar'sRestartCount. Two new operator-sidePrometheus series (
session_report_upload_attempts_totalwith result+reason labels,session_report_upload_duration_secondshistogram) for SLO and trend tracking.backend,method,url,status,attempt,took_ms, anderror. Wiring is per-SDK (S3 viaawsconfig.WithHTTPClient, GCS viastorage.Client.SetRetry(storage.WithErrorFunc), Azure via apolicy.PerRetryPoliciesentry).