Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.7-alpha.1 rejected in AMO #1

Closed
ath0mas opened this issue Sep 3, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@ath0mas
Copy link
Member

commented Sep 3, 2015

I added Gmail Manager-community 0.7-alpha.1 to AMO on September 1st
But was rejected in quick review process:

Gmail Manager-community Version 0.7-alpha.1 rejected.

Your version was rejected because of the following problems:

1. Your add-on uses the 'iframe' or 'browser' XUL elements without a 'type' attribute. If you're loading web content on them and you don't set type="content", your add-on can become a serious security threat. If you're loading chrome content, be as explicit as you can about it, so that we don't reject your add-on because of it. You can read more about it here: https://developer.mozilla.org/En/XUL/Iframe#a-browser.type

2. Hidden files and folders flagged. Hidden files and folders complicate the review process and can contain sensitive information about the system that generated the XPI. Please modify the packaging process so that these files aren't included.

3. Using __proto__ or setPrototypeOf to set a prototype is now deprecated. Use of __proto__ or setPrototypeOf to set a prototype causes severe performance degredation, and is deprecated. You should use Object.create instead. See bug https://bugzil.la/948227 for more information.

4. Obsolete Extension Manager API. The old Extension Manager API is not available in any remotely modern version of Firefox and should not be referenced in any code.

5. Extensions should not alter preferences outside of the 'extensions.' preference branch. Please make sure that all of your extension's preferences are prefixed with 'extensions.add-on-name.', where 'add-on-name' is a distinct string unique to and indicative of your add-on.

Please fix them and submit again. Thank you.

@ath0mas ath0mas added the bug label Sep 3, 2015

@ath0mas ath0mas added this to the 0.7-alpha.2 milestone Sep 3, 2015

@ath0mas

This comment has been minimized.

Copy link
Member Author

commented Oct 20, 2015

  1. 'iframe' or 'browser' XUL elements without a 'type' attribute
    • 1 use of <iframe> with type="chrome"
    • no browser element created, only retrieved
  2. Hidden files and folders
    • I don't really know what to look for...
  3. Use of proto or setPrototypeOf
    • __proto__: 9 occurrences, when instantiating gmanager_BundlePrefix ❗️
    • setPrototypeOf: not used
  4. old Extension Manager API
    • I don't really know what to look for
    • ? nsIPasswordManager used and deprecated since Gecko 1.9 (Firefox 3)
    • ? nsIPasswordManagerInternal used but unable to find reference documentation about it
    • ...
  5. preferences outside of the 'extensions.' branch
    • register preferences on longfocus.gmanager. branch ❗️

ath0mas added a commit that referenced this issue Oct 21, 2015

@ath0mas

This comment has been minimized.

Copy link
Member Author

commented Oct 21, 2015

@ath0mas ath0mas closed this Oct 21, 2015

@ath0mas ath0mas removed the bug label Nov 1, 2015

@ath0mas ath0mas removed this from the 0.7-alpha.2 milestone Nov 1, 2015

@ath0mas ath0mas added this to the 0.7 milestone Dec 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.