Activate eqeqeq in JSHint

gmarty · Nov 8, 2013 · 18c9f18 · 18c9f18
1 parent c073b9a
commit 18c9f18
Show file tree

Hide file tree

Showing 17 changed files with 197 additions and 195 deletions.
diff --git a/.jshintrc b/.jshintrc
@@ -3,7 +3,7 @@
   "bitwise": false,
   "camelcase": false,
   "curly": true,
-  "eqeqeq": false,
+  "eqeqeq": true,
   "forin": false,
   "immed": false,
   //"indent": 2,

diff --git a/src/alec/ui.js b/src/alec/ui.js
@@ -63,7 +63,7 @@ if (window['$']) {
        * Contains the fullscreen API prefix or false if not supported.
        * @type {string|boolean}
        */
-      var fullscreenSupport = JSSMS.Utils.getPrefix(['fullscreenEnabled', 'mozFullScreenEnabled']);
+      //var fullscreenSupport = JSSMS.Utils.getPrefix(['fullscreenEnabled', 'mozFullScreenEnabled']);
 
       var requestAnimationFramePrefix = JSSMS.Utils.getPrefix(['requestAnimationFrame', 'mozRequestAnimationFrame'], window);
 
@@ -319,7 +319,7 @@ if (window['$']) {
           complete: function(xhr, status) {
             var data;
 
-            if (status == 'error') {
+            if (status === 'error') {
               alert('The selected ROM file could not be loaded.');
               return;
             }
@@ -422,7 +422,7 @@ if (window['$']) {
 
         for (; num < 16 && i <= length; i++) {
           if (instructions[i]) {
-            html += '<div' + (instructions[i].address == currentAddress ? ' class="current"' : '') + '>' + instructions[i].hexAddress +
+            html += '<div' + (instructions[i].address === currentAddress ? ' class="current"' : '') + '>' + instructions[i].hexAddress +
                 (instructions[i].isJumpTarget ? ':' : ' ') +
                 '<code>' + instructions[i].inst + '</code></div>';
 

diff --git a/src/compiler/generator.js b/src/compiler/generator.js
@@ -49,7 +49,7 @@ var Generator = (function() {
         return OP_CB_STATES[opcodes[1]];
       case 0xDD:
       case 0xFD:
-        if (opcodes.length == 2) {
+        if (opcodes.length === 2) {
           return OP_DD_STATES[opcodes[1]];
         }
         return OP_INDEX_CB_STATES[opcodes[2]];
@@ -65,7 +65,7 @@ var Generator = (function() {
    */
   function convertRegisters(ast) {
     var convertRegistersFunc = function(node) {
-      if (node.type == 'Register') {
+      if (node.type === 'Register') {
         node.type = 'Identifier';
       }
 
@@ -98,7 +98,6 @@ var Generator = (function() {
                 }
               ];
               var name = fn[0].address;
-              var jumpTargetNb = fn[0].jumpTargetNb;
               var tstates = 0;
 
               fn = fn
@@ -252,7 +251,7 @@ var Generator = (function() {
                 // Inject data about current branch into a comment.
                 fn[0][0].leadingComments = [].concat({
                   type: 'Line',
-                  value: ' Nb of bytecodes jumping here: ' + jumpTargetNb
+                  value: ' Nb of bytecodes jumping here: ' + fn[0].jumpTargetNb
                 }, fn[0][0].leadingComments);*/
 
               // Flatten the array.
@@ -265,13 +264,13 @@ var Generator = (function() {
 
               // Append `this` to all identifiers.
               body = JSSMS.Utils.traverse(body, function(obj) {
-                if (obj.type && obj.type == 'Identifier' && whitelist.indexOf(obj.name) == -1) {
+                if (obj.type && obj.type === 'Identifier' && whitelist.indexOf(obj.name) === -1) {
                   obj.name = 'this.' + obj.name;
                 }
                 return obj;
               });
 
-            return {
+              return {
                 'type': 'Program',
                 'body': [
                   {

diff --git a/src/compiler/opcodes-CB.js b/src/compiler/opcodes-CB.js
@@ -17,6 +17,8 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+/* global o */
+
 'use strict';
 
 var opcodeTableCB = [];
@@ -41,7 +43,7 @@ var regs = {
       ast: o[op].apply(null, regs[reg])
     });
     // @todo Refactor and clean this section.
-    if (reg != '(HL)') {
+    if (reg !== '(HL)') {
       opcodeTableDDCB.push({
         name: 'LD ' + reg + ',' + op + ' (IX)',
         ast: o['LD_' + op].apply(null, ['ixH', 'ixL'].concat(regs[reg]))

diff --git a/src/compiler/opcodes-DD-FD.js b/src/compiler/opcodes-DD-FD.js
@@ -268,7 +268,7 @@ function generateIndexTable(index) {
       ast: o.CP_X(registerH, registerL)
     },
     0xCB:
-        index == 'IX' ? opcodeTableDDCB : opcodeTableFDCB,
+        index === 'IX' ? opcodeTableDDCB : opcodeTableFDCB,
     0xE1: {
       name: 'POP ' + index,
       ast: o.POP(registerH, registerL)