gmcgibbon
Follow
Pinned
2,087 contributions in the last year
Activity overview
Contribution activity
January 2021
Created 46 commits in 14 repositories
Created 8 repositories
- gmcgibbon/Molinillo Ruby
- gmcgibbon/rubygems Ruby
- gmcgibbon/net-ftp Ruby
- gmcgibbon/net-http Ruby
- gmcgibbon/strscan Ruby
- gmcgibbon/matrix Ruby
- gmcgibbon/logger Ruby
- gmcgibbon/webpacker Ruby
Created a pull request in ruby/ruby that received 14 comments
Replace iff with if
iff means if and only if, but readers without that knowledge might assume this to be a spelling mistake (see examples). To me, this seems like excl…
+18
−18
•
14
comments
Opened 14 other pull requests in 12 repositories
Shopify/quilt
1
open
1
merged
rails/rails
1
merged
1
open
CocoaPods/Molinillo
1
merged
rubygems/rubygems
1
merged
ruby/strscan
1
merged
ruby/matrix
1
merged
ruby/net-ftp
1
merged
ruby/net-http
1
merged
ruby/logger
1
merged
rails/webpacker
1
merged
Shopify/identity_cache
1
merged
Shopify/web-configs
1
merged
Reviewed 14 pull requests in 4 repositories
rails/rails 9 pull requests
- Guides: Missing erb tags for stylesheet_pack_tag [ci skip]
- Add cosmetic improvements to the Webpacker guide
- Fix doc: stylesheet_include_tag -> stylesheet_link_tag
- Update test docs in "contributing to Rails" guide [ci skip]
- Webpacker guide: remove Basecamp reference + fix broken links [docs] [skip-ci]
- [ci skip]: improve Rails ActiveRecord documentation
- Raise error on unpermitted open redirects.
- Fix test failing on ruby master
- Pass service_name param to DirectUploadsController
Shopify/quilt 3 pull requests
Shopify/identity_cache 1 pull request
Shopify/packwerk 1 pull request
100
contributions
in private repositories
Jan 4 – Jan 25