New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faceted track selector nonfunctional in IE 11 #1036

Closed
rbuels opened this Issue Apr 17, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@rbuels
Collaborator

rbuels commented Apr 17, 2018

In JBrowse 1.13.1:

image

@rbuels rbuels added this to the 1.14.1 milestone Apr 17, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Apr 17, 2018

works in Edge 15

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Apr 17, 2018

I think on dev branch IE11 is actually throwing Out of stack space errors (different from the 1.13.1 blank screen) works on Edge though

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Apr 17, 2018

Actually the Out of stack space error goes away with clear cache on ie11

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Apr 18, 2018

I've done a bit of digging, this seems to be a bug deep in the guts of dojo/dom-style. The only way to fix it would seem to be to downgrade dojo, but that seems likely to cause other problems, especially given that we've based a lot of the css_isolation style tweaks on newer dojo and dijit dom structures.

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Apr 18, 2018

Interesting...I was wondering a bit ago if the faceted selector could be replaced by a dgrid instead of dojox grid? That would be modernizing the system a bit and could avoid that backtracking for browser compat.

@rbuels rbuels closed this in 544e3e9 May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment