Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite remotebinaryfile and add request aggregation #1155

Closed
rbuels opened this Issue Aug 1, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@rbuels
Copy link
Collaborator

rbuels commented Aug 1, 2018

make the request aggregation logic reusable by BAM and CRAM stores for mate pair resolution

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Aug 14, 2018

I am not sure if this is going to be common but sometimes, I think if one of the byte range request fails, it makes the whole track error out and browser needs to be refreshed

error_out

I don't recall if it would error out like this in previous versions. The error message seems somewhat confusing too being a TypeError, but I know many javascript errors kind of just end up being TypeError

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Aug 14, 2018

If you want I can make a new issue for this @rbuels or maybe hold out :)

@rbuels

This comment has been minimized.

Copy link
Collaborator Author

rbuels commented Aug 14, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Aug 14, 2018

Added as #1175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.