New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing reference sequence name does not change refseqs if generate-names has been run #1193

Closed
cmdcolin opened this Issue Aug 26, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@cmdcolin
Contributor

cmdcolin commented Aug 26, 2018

If you type the reference sequence name into the location bar, and if generate-names was run, then it does not change reference sequences if you press Enter or hit Go

Appears to have been introduced in the 1.15.0 release

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Aug 26, 2018

Contributor

Due to 6710d12 found by git bisect

Contributor

cmdcolin commented Aug 26, 2018

Due to 6710d12 found by git bisect

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Aug 26, 2018

Contributor

I reverted this git commit. The original motivation of "hiding" results even with real search engine hits due to a missing track for the purpose of private tracks seems problematic. I think it is better to find a different strategy (e.g. an alternative name index) because there are too many loopholes made possible with this including this bug

I also started a small hash store jasmine spec as none really existed previously

Contributor

cmdcolin commented Aug 26, 2018

I reverted this git commit. The original motivation of "hiding" results even with real search engine hits due to a missing track for the purpose of private tracks seems problematic. I think it is better to find a different strategy (e.g. an alternative name index) because there are too many loopholes made possible with this including this bug

I also started a small hash store jasmine spec as none really existed previously

@cmdcolin cmdcolin closed this Aug 26, 2018

@cmdcolin cmdcolin added this to the 1.15.3 milestone Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment