New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout on granular rect layout? #1210

Closed
cmdcolin opened this Issue Sep 20, 2018 · 4 comments

Comments

Projects
None yet
1 participant
@cmdcolin
Contributor

cmdcolin commented Sep 20, 2018

The current GranularRectLayout is improved performance wise but maybe we could get a little better feature packing?

Increasing the layout resolution a little bit I think could help, but I haven't measured if that causes any performance changes

screenshot-localhost-2018 09 20-13-13-37
after

screenshot-localhost-2018 09 20-13-16-07
before

diff --git a/src/JBrowse/View/Track/CanvasFeatures.js b/src/JBrowse/View/Track/CanvasFeatures.js
index 9e928893e..09d090fd9 100644
--- a/src/JBrowse/View/Track/CanvasFeatures.js
+++ b/src/JBrowse/View/Track/CanvasFeatures.js
@@ -314,7 +314,7 @@ return declare(
             // height and marginBottom (parseInt in case one or both are functions), or default to 3 if the
             // calculation didn't result in anything sensible.
             var pitchY = this.getConf('layoutPitchY') || 4;
-            this.layout = new Layout({ pitchX: 4/scale, pitchY: pitchY, maxHeight: this.getConf('maxHeight'), displayMode: this.displayMode });
+            this.layout = new Layout({ pitchX: 1/scale, pitchY: pitchY, maxHeight: this.getConf('maxHeight'), displayMode: this.displayMode });
             this._layoutpitchX = 4/scale;
@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 21, 2018

Contributor

Should be fixed around e56cb1a

Contributor

cmdcolin commented Sep 21, 2018

Should be fixed around e56cb1a

@cmdcolin cmdcolin closed this Sep 21, 2018

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 21, 2018

Contributor

If we see any issues with this, specifically for very long features when zoomed in at a high level, then feel free to make a new issue

Contributor

cmdcolin commented Sep 21, 2018

If we see any issues with this, specifically for very long features when zoomed in at a high level, then feel free to make a new issue

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 21, 2018

Contributor

This commit e56cb1a causes a rendering issue at high zoom level with BAM files and probably other track types

screenshot-localhost-2018 09 21-17-54-22

Reverting out and I guess reopening :)

Contributor

cmdcolin commented Sep 21, 2018

This commit e56cb1a causes a rendering issue at high zoom level with BAM files and probably other track types

screenshot-localhost-2018 09 21-17-54-22

Reverting out and I guess reopening :)

@cmdcolin cmdcolin reopened this Sep 21, 2018

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 21, 2018

Contributor

Actually looks like there was just an additional reference to the pitchX that I neglected, committed as 3046cb9 and close again

Contributor

cmdcolin commented Sep 21, 2018

Actually looks like there was just an additional reference to the pitchX that I neglected, committed as 3046cb9 and close again

@cmdcolin cmdcolin closed this Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment