New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters in SNPCoverage don't do anything #1241

Closed
cmdcolin opened this Issue Oct 24, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@cmdcolin
Copy link
Contributor

cmdcolin commented Oct 24, 2018

Using 1.15.4 I found that "Hide unspliced reads" in a SNPCoverage track causes crash.

I think all the other feature filters also have issues but it they were just less noticeable because they didn't cause a crash

To be to the point, the reason is that a CoverageFeature gets passed through the filter and then calls to things like f.get('secondary_alignment') returns undefined and !f.get('secondary_alignment') is just true. More complicated filters like Hide unspliced reads operate on the undefined value of f.get('cigar') so it causes the crash

cmdcolin added a commit that referenced this issue Oct 27, 2018

@cmdcolin cmdcolin closed this Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment