New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate-names can fail to index some items #1275

Closed
cmdcolin opened this Issue Dec 6, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Dec 6, 2018

It was found that generate-names can fail to index some items

Reverting c9c284c can fix it but it introduces a memory leak

A modification like this (https://github.com/GMOD/jbrowse/compare/dev...fix_generate_names?expand=1) can fix it but it's not actually clear to me why. More specifically, if you change the while loop to an if statement, it doesn't work, but that doesn't really make obvious sense to me

If possible a failing test case and a fix would be good to have

@rbuels rbuels added this to the 1.16.0 milestone Dec 7, 2018

@rbuels rbuels added the bug label Dec 7, 2018

@rbuels rbuels self-assigned this Dec 7, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Dec 11, 2018

@rbuels I went ahead and did some looking at this since I was in perl-land and found the issue was due to make_operations being able to return empty. I created this PR to fix #1283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment