New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading files from CORS without content-range headers accessible #1289

Closed
cmdcolin opened this Issue Dec 21, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Dec 21, 2018

This should be as easy as removing this hardcoded check dev...no_content_range_check

Allows a wider range of CORS resources to be accessed

Should just test this change on a number of filetypes to see if it has any weird behavior but it appears to work fine on for example 2bit and bigwig

@rbuels rbuels added this to the 1.16.1 milestone Dec 21, 2018

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Dec 26, 2018

BAM, Tabix, and CRAM seem to have trouble even with this change added

Stores that appear to work with that change include TwoBit, BigWig, BigBed

If I go to 1.15.1, then Tabix and BAM seem to work though (this is the first version sans http-range-fetcher)

@cmdcolin

This comment has been minimized.

Copy link
Contributor

cmdcolin commented Dec 26, 2018

Should be fixed now

@cmdcolin cmdcolin closed this Dec 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment