Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swipe scroll on mac and chrome triggers forward or back scroll #1397

Closed
nathandunn opened this issue Jul 3, 2019 · 12 comments

Comments

Projects
None yet
2 participants
@nathandunn
Copy link
Contributor

commented Jul 3, 2019

When scrolling to the left or the right on the mac in Chrome with JBrowse 1.16.5 (and similarly Apollo) it triggers a back or forward scroll. Per topic: https://groups.google.com/a/lbl.gov/forum/#!topic/apollo/Dk2AUoyQJY4

  • JBrowse version: 1.16.5
  • Web browser being used: Chrome
  • Operating system if relevant: Mac
  • This occurs in and outside an iFrame

More details:

  • when tracklist=1 I see the affect when scrolling to the right (if there is forward history), but but not the left
  • when tracklist=0 (as it in Apollo most of the time) you always see the affect (if there is history forward or back)
@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Not observed at all in JBrowse2 AFAICT

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Usually this is when something on the page hits a horizontal scroll limit (at least with trello).

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Works with all versions 1.12 to 08c9e7e (June 12th) . . I'll roll it forward and see

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

This fails: 8a041eb

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Testing:

@cmdcolin

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

I see. That's unfortunate. We'll have to roll back that change I guess. There is a config flag you can add to jbrowse.conf "alwaysStopScrollBubble=true" that may help this. Can you try that

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

@cmdcolin that definitely fixes it. Could we just change the default to true? It might be the simpler fix.

@cmdcolin

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Yes that should be fine actually. That code change was only designed to affect vertical scrolling but is somehow affecting left right scrolling with the mac touchpad...works fine with my touchpad weirdly enough. We can either try to fix that just turn that config item to true by default

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

@cmdcolin I'm not sure the behavior its trying to fix, but setting it to true by default works for me. Do you want to make that fix or should I?

@cmdcolin

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

This change should fix it instead 4b44f87

I just pushed it it to dev in case you want to test

@cmdcolin cmdcolin closed this Jul 3, 2019

@cmdcolin

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Thanks for catching this

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

@cmdcolin Tested and works. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.