dijit dialog scrolling bug, chrome 31/osx 10.9 #386

Closed
rbuels opened this Issue Nov 25, 2013 · 6 comments

Comments

Projects
None yet
3 participants
@rbuels
Collaborator

rbuels commented Nov 25, 2013

From #318 comments:

HTML variants tracks I've got a small bug when I arrive at the end of
the popup (when scrolling down with my trackpad): it goes back to the
top as a cycle.

What browser and version do you see this on?

Version 31.0.1650.57 and OSX 10.9

@ghost ghost assigned Erik-J-D Nov 27, 2013

@Erik-J-D

This comment has been minimized.

Show comment
Hide comment
@Erik-J-D

Erik-J-D Nov 27, 2013

Contributor

Still occurs in chrome 32.

Contributor

Erik-J-D commented Nov 27, 2013

Still occurs in chrome 32.

@rbuels

This comment has been minimized.

Show comment
Hide comment
@rbuels

rbuels Dec 2, 2013

Collaborator

this is an upstream dijit bug: https://bugs.dojotoolkit.org/ticket/17602

Collaborator

rbuels commented Dec 2, 2013

this is an upstream dijit bug: https://bugs.dojotoolkit.org/ticket/17602

@rbuels rbuels removed this from the Release 2.0.0 milestone Feb 13, 2014

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Mar 11, 2014

Contributor

I stumbled on a pretty good clue to this problem in http://stackoverflow.com/questions/8563374/why-is-two-finger-scrolling-behaving-differently-on-two-separate-ipads

"-webkit-overflow-scrolling uses the iPad's built in functionality (the touch acceleration and bounce). However, if the contents in your div change, or you manually move the contents inside the div (ie you made your own div scrollbar and are scrolling the contents), enabling this will mess things up. What it will do is make the "top" of the scroll able div wherever it happens to be located. What does this mean? If your contents are scrolled half way down and then you add new content to the div, with -webkit-overflow-scrolling:touch, the very top of the touch-scroll area will be half way down your div. You will not be able touch-scroll back to the top.

Contributor

cmdcolin commented Mar 11, 2014

I stumbled on a pretty good clue to this problem in http://stackoverflow.com/questions/8563374/why-is-two-finger-scrolling-behaving-differently-on-two-separate-ipads

"-webkit-overflow-scrolling uses the iPad's built in functionality (the touch acceleration and bounce). However, if the contents in your div change, or you manually move the contents inside the div (ie you made your own div scrollbar and are scrolling the contents), enabling this will mess things up. What it will do is make the "top" of the scroll able div wherever it happens to be located. What does this mean? If your contents are scrolled half way down and then you add new content to the div, with -webkit-overflow-scrolling:touch, the very top of the touch-scroll area will be half way down your div. You will not be able touch-scroll back to the top.

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin May 3, 2014

Contributor

I happened to stumble into the dojo irc while someone was talking about this bug and suggested adding "overflow:hidden" to the body tag to prevent this behavior. I don't see any problems with doing this for now in JBrowse, even though this is slightly hackish (doesn't fix the root cause of the upstream bug) but it at least fixes scrolling on chrome and safari.

i can commit this change after some testing perhaps

Contributor

cmdcolin commented May 3, 2014

I happened to stumble into the dojo irc while someone was talking about this bug and suggested adding "overflow:hidden" to the body tag to prevent this behavior. I don't see any problems with doing this for now in JBrowse, even though this is slightly hackish (doesn't fix the root cause of the upstream bug) but it at least fixes scrolling on chrome and safari.

i can commit this change after some testing perhaps

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Jul 21, 2014

Contributor

Reopening because this change has been puleld from the codebase for being problematic.

Contributor

cmdcolin commented Jul 21, 2014

Reopening because this change has been puleld from the codebase for being problematic.

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Apr 28, 2017

Contributor

this is actually way less bad in recent chrome versions than it used to be. safari is still affected, but I think it is reasonable to just close and forget

(recall: symptom is that scrolling through a view dialog box makes it jump back up to the top)

Contributor

cmdcolin commented Apr 28, 2017

this is actually way less bad in recent chrome versions than it used to be. safari is still affected, but I think it is reasonable to just close and forget

(recall: symptom is that scrolling through a view dialog box makes it jump back up to the top)

@cmdcolin cmdcolin closed this Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment