Make "remove highlighting" more obvious #445

Closed
pjhale opened this Issue Feb 17, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@pjhale

pjhale commented Feb 17, 2014

Minor issue... I've had a few users complain to me that its not inherently obvious how to remove highlighting. Would it be possible to either add another button in the main viewer next to the highlight button or enable the highlight button on a second click remove a previous highlighted section?

Thanks,
Paul Hale
Mouse Genome Informatics

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Mar 18, 2014

Contributor

I tried to tackle this problem and I used the approach of adding a second button instead of making a 'three state' button. From an implementation point of view, the second button was easier, but i'm not sure if it is ideal. Overall, the 'three state' button might be better for usability and aesthetics so I'll keep this issue open
First demo:
jbrowse-xii
jbrowse-xii-2

Contributor

cmdcolin commented Mar 18, 2014

I tried to tackle this problem and I used the approach of adding a second button instead of making a 'three state' button. From an implementation point of view, the second button was easier, but i'm not sure if it is ideal. Overall, the 'three state' button might be better for usability and aesthetics so I'll keep this issue open
First demo:
jbrowse-xii
jbrowse-xii-2

@pjhale

This comment has been minimized.

Show comment
Hide comment
@pjhale

pjhale Mar 18, 2014

Thanks for the reply! I agree that the three state button is probably ideal but this is definitely a step in the right direction.

pjhale commented Mar 18, 2014

Thanks for the reply! I agree that the three state button is probably ideal but this is definitely a step in the right direction.

@cmdcolin cmdcolin added this to the Release 1.11.4 milestone Mar 26, 2014

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Apr 7, 2014

Contributor

I have implemented the three state button on a feature branch 'clear_highlight_button' which can be downloaded here https://github.com/GMOD/jbrowse/archive/clear_highlight_button.zip
I think it's merge-ready and i'd like to get it out in the next release but i'd like to see if there's any concerns before merging.
The most notable (or questionable) change is that the entire button is now stored in the icon file (https://github.com/GMOD/jbrowse/blob/clear_highlight_button/img/tristate.png) because i found it hard to get the normal dijit button style to apply to the dojox button.

Contributor

cmdcolin commented Apr 7, 2014

I have implemented the three state button on a feature branch 'clear_highlight_button' which can be downloaded here https://github.com/GMOD/jbrowse/archive/clear_highlight_button.zip
I think it's merge-ready and i'd like to get it out in the next release but i'd like to see if there's any concerns before merging.
The most notable (or questionable) change is that the entire button is now stored in the icon file (https://github.com/GMOD/jbrowse/blob/clear_highlight_button/img/tristate.png) because i found it hard to get the normal dijit button style to apply to the dojox button.

@cmdcolin cmdcolin closed this May 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment