Chrome fails to load on certain PC configurations #505

Closed
pjhale opened this Issue Aug 21, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@pjhale

pjhale commented Aug 21, 2014

I had a user write in saying that they were unable to access JBrowse via Google Chrome on a PC. Other users on nearly identical configurations had no issues... nor did she have an issue accessing it via Firefox. Looking into the developer tools the console logged the following error for her...

Failed to load resource: the server responded with a status of 404 (Not Found) http://jbrowse.informatics.jax.org/src/dgrid/TouchScroll.js

Solution to this problem (kindly suggested to me by Emily Greenfest-Allen via the mailing list) is to add a few files from the dgrid project (https://github.com/sitepen/dgrid) into the src/dgrid directory and create a new directory named util/ here.

  1. TouchScroll.js
  2. util/has-css3.js
  3. util/touch.js

This has solved my users problem as well however not being terribly familiar with dgrid I'm not sure if there is an underlying problem as well. Also of note is that Emily had found this was an issue pertaining only to touch screen PC's but the user I was working with was on a regular Dell laptop.

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Aug 21, 2014

Contributor

Thanks for finding this. Resolving these types of issues might be a little tricky since it is based off of the dojo build cycle. I think these files are probably automatically removed from the release instances, but maybe we can find where to specify the dependency

Contributor

cmdcolin commented Aug 21, 2014

Thanks for finding this. Resolving these types of issues might be a little tricky since it is based off of the dojo build cycle. I think these files are probably automatically removed from the release instances, but maybe we can find where to specify the dependency

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Aug 29, 2014

Contributor

I found another case where this was happening here so I sort of expedited this fix http://sourceforge.net/p/gmod/mailman/message/32773795/

I also wanted to make sure I was doing it right so I asked on IRC

16:29 < cdiesh> hi there. I am compiling dgrid into our project but it seems like TouchScroll.js is being excluded from the build
16:30 < cdiesh> it seems to be conditionally included based on dojo/has!touch?./TouchScroll
16:31 < cdiesh> that shouldn't make it excluded from the build though should it?
16:31 < kgf> it will unless touch is predefined in staticHasFeatures (which you don't want unless touch devices are your ONLY target)
16:32 < kgf> so the other choice is to explicitly list it in your layer's includes
16:33 < cdiesh> kgf: ah thanks. so I can include it in my build profile instead of modifying dgrid?
16:33 < kgf> yes

So, after all that I made a patch to include it into our release build

Contributor

cmdcolin commented Aug 29, 2014

I found another case where this was happening here so I sort of expedited this fix http://sourceforge.net/p/gmod/mailman/message/32773795/

I also wanted to make sure I was doing it right so I asked on IRC

16:29 < cdiesh> hi there. I am compiling dgrid into our project but it seems like TouchScroll.js is being excluded from the build
16:30 < cdiesh> it seems to be conditionally included based on dojo/has!touch?./TouchScroll
16:31 < cdiesh> that shouldn't make it excluded from the build though should it?
16:31 < kgf> it will unless touch is predefined in staticHasFeatures (which you don't want unless touch devices are your ONLY target)
16:32 < kgf> so the other choice is to explicitly list it in your layer's includes
16:33 < cdiesh> kgf: ah thanks. so I can include it in my build profile instead of modifying dgrid?
16:33 < kgf> yes

So, after all that I made a patch to include it into our release build

@cmdcolin cmdcolin closed this in 3f4dee3 Aug 29, 2014

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 4, 2014

Contributor

I just wanted to stop by and say this actually makes jbrowse work on tablets now :) Really fun!

-Colin

Contributor

cmdcolin commented Sep 4, 2014

I just wanted to stop by and say this actually makes jbrowse work on tablets now :) Really fun!

-Colin

@pjhale

This comment has been minimized.

Show comment
Hide comment
@pjhale

pjhale Sep 4, 2014

Awesome! I'll have to test it out when I get a chance. Windows, Android, Apple?

pjhale commented Sep 4, 2014

Awesome! I'll have to test it out when I get a chance. Windows, Android, Apple?

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Sep 4, 2014

Contributor

I tested on an android tablet briefly. it was a little slow but the side scrolling with touch is very fun.

Contributor

cmdcolin commented Sep 4, 2014

I tested on an android tablet briefly. it was a little slow but the side scrolling with touch is very fun.

@cmdcolin cmdcolin referenced this issue Oct 13, 2014

Closed

IPad support #439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment