Google Chrome 38 has problems with certain popups #522

Closed
cmdcolin opened this Issue Oct 17, 2014 · 9 comments

Comments

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented Oct 17, 2014

Example screenshot of google chrome 38 on ubuntu:

bad-vcf-dialog

I don't remember this happening on any older chrome versions

Tested on Mac OSX and ubuntu

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
Contributor

cmdcolin commented Oct 17, 2014

cmdcolin added a commit that referenced this issue Oct 21, 2014

Add patch for google chrome 38 which adds preliminary es6 features. T…
…his makes it so that the array element has a values() function. See #522
@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Oct 22, 2014

Contributor

Another workaround that can help users with existing versions of jbrowse would be to run the following code (copy and paste into URL bar)

javascript:delete Array.prototype.values

Contributor

cmdcolin commented Oct 22, 2014

Another workaround that can help users with existing versions of jbrowse would be to run the following code (copy and paste into URL bar)

javascript:delete Array.prototype.values

@pjhale

This comment has been minimized.

Show comment
Hide comment
@pjhale

pjhale Oct 23, 2014

This appears to have also created a similar problem with feature detail pages too. I first noticed it in alias's but it looks like it has broken anything with more than one value (again only on chrome). I've just tried it out with my dev version which should be up to date with your recent fix and it still appears broken.

pjhale commented Oct 23, 2014

This appears to have also created a similar problem with feature detail pages too. I first noticed it in alias's but it looks like it has broken anything with more than one value (again only on chrome). I've just tried it out with my dev version which should be up to date with your recent fix and it still appears broken.

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Oct 23, 2014

Contributor

Hi @pjhale.
I think you're right...this bug affects arrays in other features too, not just VCF.

I tried making a couple of array types in a GFF (i.e. multiple Dbxrefs), but it appeared to work ok for me.

Soo..I'm curious what could be causing continued issues for you!

Contributor

cmdcolin commented Oct 23, 2014

Hi @pjhale.
I think you're right...this bug affects arrays in other features too, not just VCF.

I tried making a couple of array types in a GFF (i.e. multiple Dbxrefs), but it appeared to work ok for me.

Soo..I'm curious what could be causing continued issues for you!

@pjhale

This comment has been minimized.

Show comment
Hide comment
@pjhale

pjhale Oct 23, 2014

Looking at the yeast sample data there are a few array type features and they still give the error even with the update. I'll keep looking and see if its something on my end.

pjhale commented Oct 23, 2014

Looking at the yeast sample data there are a few array type features and they still give the error even with the update. I'll keep looking and see if its something on my end.

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Oct 23, 2014

Contributor

My bad I was testing in firefox! I forgot it was chrome only.

Contributor

cmdcolin commented Oct 23, 2014

My bad I was testing in firefox! I forgot it was chrome only.

@cmdcolin cmdcolin changed the title from Google Chrome 38 has problems with VCF popups to Google Chrome 38 has problems with popup dialogs Oct 27, 2014

@cmdcolin cmdcolin changed the title from Google Chrome 38 has problems with popup dialogs to Google Chrome 38 has problems with certain popups Oct 27, 2014

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Nov 12, 2014

Contributor

This is fixed in the repo, so I'll close this for now

Contributor

cmdcolin commented Nov 12, 2014

This is fixed in the repo, so I'll close this for now

@cmdcolin cmdcolin closed this Nov 12, 2014

@cmdcolin

This comment has been minimized.

Show comment
Hide comment
@cmdcolin

cmdcolin Jan 22, 2015

Contributor

This seems to have only affected Chrome 38?

I tested simply opening the same dialog boxes on jbrowse.org in Chrome 39 on Mac OSX and Chrome 40 on Ubuntu and it does not have any problems.

Can test this in the developers console by entering "Array.prototype.values" will return undefined. Previously it returned the "function values() ..."

Contributor

cmdcolin commented Jan 22, 2015

This seems to have only affected Chrome 38?

I tested simply opening the same dialog boxes on jbrowse.org in Chrome 39 on Mac OSX and Chrome 40 on Ubuntu and it does not have any problems.

Can test this in the developers console by entering "Array.prototype.values" will return undefined. Previously it returned the "function values() ..."

@cmdcolin cmdcolin added this to the 1.11.6 milestone Jan 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment