New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go to the result immediately when clicking a search result in name completion dropdown #616

Closed
enuggetry opened this Issue Jun 26, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@enuggetry
Contributor

enuggetry commented Jun 26, 2015

I noted the dropdown items in the search box cannot be selected. Therefore, although the autocomplete provides some hints as to what is found, but you still have to type then whole feature name out.

screenshot_wed_jun_24_09 20 31

Conventionally, if an item is clicked, it should replace the search box content, or something.

I think it should be an easy fix, but wondering if there is any reasoning behind it.

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Jan 27, 2017

I think you can click them? What platform can you not click them?

@enuggetry

This comment has been minimized.

Contributor

enuggetry commented Jan 27, 2017

you can click them, but you still have to click "go". That's what I meant.

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 1, 2018

Oh, so you should just go there when you click them. That's a good idea.

@rbuels rbuels added this to the 1.12.4 milestone Feb 1, 2018

@rbuels rbuels changed the title from Search dropdown items can't be clicked. to go to the result immediately when clicking a search result in name completion dropdown Feb 1, 2018

@rbuels rbuels modified the milestones: 1.12.4, 1.13.0, 1.12.5 Feb 2, 2018

@wafflebot wafflebot bot added the in progress label Feb 21, 2018

@rbuels rbuels closed this in #1001 Feb 21, 2018

rbuels added a commit that referenced this issue Feb 21, 2018

Merge pull request #1001 from GMOD/go_to_feature_on_click
go to search completion immediately on click, fixes #616

@wafflebot wafflebot bot removed the in progress label Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment