New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FASTA save button missing in Safari #714

Closed
kkarra opened this Issue Mar 16, 2016 · 7 comments

Comments

Projects
None yet
4 participants
@kkarra

kkarra commented Mar 16, 2016

When you click on a CanvasFeature the pop-up box displays the sequence and a save button in other browsers. But, in Safari Version 9.0 (11601.1.56) - the button is missing.

@enuggetry

This comment has been minimized.

Contributor

enuggetry commented Mar 16, 2016

I can reproduce this. Thanks for bring it up.

This button does not show up in Safari:
ice_screenshot_20160316-160746

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Mar 21, 2016

Probably related to this #412

I forget the exact issues with this but it might be able to be re-fixed on safari

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Jun 20, 2016

The FileSaver.js library that jbrowse uses sort of demonstrates the type of issues that are seen with safari https://eligrey.com/demos/FileSaver.js/

Instead of saving the file, it creates a new tab with the content, and then the user has to save the contents to a file themselves.

See also eligrey/FileSaver.js#12

@rbuels rbuels added this to the 1.12.4 milestone Jan 30, 2018

@rbuels rbuels added the help wanted label Jan 30, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Jan 30, 2018

Well, back 3.5 years ago when we made this feature, it couldn't be made to work on Safari, because Safari didn't support creating files on the client side. But that may have changed with newer versions of Safari in the years since.

@cmdcolin you're on mac right? do you have time to look into 1.) why the button is actually missing (it's supposed to be grayed out/disabled), 2.) whether the download functionality can be made to work in recent versions of safari, so we could maybe enable it for new Safaris. Assigning it to you for now, if you don't have time, just un-assign it.

@rbuels rbuels modified the milestones: 1.12.4, 1.13.0, 1.12.5 Feb 2, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 20, 2018

i just confirmed that save-generated-files works on Safari 11. Anybody have safari 10 or 9 to test?

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 20, 2018

I'm trying now to get a free Browserstack account for us to poke at this manually.

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 20, 2018

Got a browerstack account, tested that Safari 10 and 11 both support the generated file download, but Safari 9 and below do not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment