New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combination track crashes if Alignments2 track is used #771

Closed
cmdcolin opened this Issue Jun 24, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented Jun 24, 2016

If Alignments2 are used in a combination track, then it causes errors and is unusable

BlockBased.js:754 failed to render menu item: TypeError: Cannot read property 'tagName' of undefined
CanvasFeatures.js:1013 Uncaught TypeError: Cannot read property 'offsetWidth' of undefined

This affects older jbrowse 1.10 branch versions as well as recent versions

@rbuels rbuels added this to the 1.12.4 milestone Jan 30, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Jan 30, 2018

@cmdcolin is this still an issue in recent builds?

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 2, 2018

Yep, seems to still apply. It seems to be related to the track label not being initialized

Not sure why that happens just for Alignments2 tracks but I found a line of code that might be the culprit and a possible fix

diff --git a/src/JBrowse/View/Track/Combination.js b/src/JBrowse/View/Track/Combination.js
index 6e2beca..f89e2bc 100644
--- a/src/JBrowse/View/Track/Combination.js
+++ b/src/JBrowse/View/Track/Combination.js
@@ -597,7 +597,7 @@ renderResultsTrack: function() {

             // destroy the makeTrackLabel function of the results track, so that to the user it is exactly the same as the outer track

-            thisB.resultsTrack.makeTrackLabel = function() {};
+            //thisB.resultsTrack.makeTrackLabel = function() {};

             // setViewInfo on results track
             thisB.resultsTrack.setViewInfo (thisB.genomeView, resultsHeightUpdate,
@@ -958,7 +958,6 @@ _trackMenuOptions: function() {
              }]
         );
     }

     return o;
 },

@rbuels rbuels modified the milestones: 1.12.4, 1.12.5 Feb 2, 2018

@wafflebot wafflebot bot added the in progress label Feb 21, 2018

@rbuels rbuels closed this in 96591ac Feb 21, 2018

@wafflebot wafflebot bot removed the in progress label Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment