New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"outrons" not rendered with neat features #931

Closed
scottcain opened this Issue Oct 6, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@scottcain
Member

scottcain commented Oct 6, 2017

For features that start and/or end with introns (apparently called "outrons" sometimes), NeatCanvasFeatures doesn't render them at all, though JBrowse is aware that there is more to the feature, since it draws the strand arrows in the right place (which is visually confusing, since the strand arrow is sitting out there in nowheresville). This may also be an issue with NeatHTMLFeatures but I haven't tested it. Example screenshots are below.

"regular" features"
regular features

Neat features:
neatfeatures

@rbuels rbuels added this to the 1.12.4 milestone Jan 25, 2018

@nathandunn nathandunn assigned nathandunn and enuggetry and unassigned nathandunn Jan 25, 2018

@nathandunn

This comment has been minimized.

Contributor

nathandunn commented Jan 25, 2018

@rbuels I'm happy to test this, but I think its is more of @enuggetry 's code.

@nathandunn nathandunn self-assigned this Jan 25, 2018

@enuggetry

This comment has been minimized.

Contributor

enuggetry commented Jan 25, 2018

@enuggetry

This comment has been minimized.

Contributor

enuggetry commented Feb 16, 2018

image

Red is HTML
Yellow is Canvas

@enuggetry enuggetry closed this Feb 16, 2018

@wafflebot wafflebot bot removed the in progress label Feb 16, 2018

@nathandunn

This comment has been minimized.

Contributor

nathandunn commented Feb 16, 2018

👍 Looks great.

enuggetry added a commit that referenced this issue Feb 28, 2018

collective fixes/additions
consistify gradient on/off config option for NeatCanvasFeatures and NeatHTMLFeatures.
Restore NeatCanvasFeatures gradients #985,#982
add Outrons #992, #931
disable gradiants for alignment tracks #992
fixed uncaught typeerror #992
fixed gradient default NeatHTMLFeatures #992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment