New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref sequence order enhancements #1007

Merged
merged 9 commits into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@rbuels
Collaborator

rbuels commented Feb 26, 2018

adds --noSort option to prepare-refseqs.pl that preserves the order of the input sequence file.

adds support for a by_list value for refSeqOrder in the tracks.conf, which allows people to manually specify the order of their reference sequences

fixes #925 and #919

@rbuels rbuels added the feature req label Feb 26, 2018

@rbuels rbuels added this to the 1.12.5 milestone Feb 26, 2018

@rbuels rbuels self-assigned this Feb 26, 2018

@rbuels rbuels requested a review from cmdcolin Feb 26, 2018

@wafflebot wafflebot bot added the in progress label Feb 26, 2018

@rbuels rbuels requested a review from rdhayes Feb 26, 2018

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 26, 2018

Looks good to me :) tested noSort option and the refSeqOrderList override. and they both work.

I guess I'm wondering, if refSeqOrderList exists, can we just get rid of manually setting refSeqOrder: "by_list"?

@rbuels rbuels merged commit 4cf41b7 into dev Feb 27, 2018

@wafflebot wafflebot bot removed the in progress label Feb 27, 2018

@rbuels rbuels deleted the refseqorder branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment