New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "loading screen" #1008

Merged
merged 2 commits into from Feb 27, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented Feb 26, 2018

This PR adds a basic "loading screen" while the browser is waiting to be initialized. Then, after the loadRefSeqs milestone is passed, the text is removed. This helps with slow connections and large refSeqs.json files

This was documented as a customization that users can make to index.html in the configuration guide, but it seems like it could be useful to have it by default? http://gmod.org/wiki/JBrowse_Configuration_Guide#Configure_a_Loading_Page

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 27, 2018

@cmdcolin could you add a blurb about it to the release notes?

@rbuels rbuels added this to the 1.12.5 milestone Feb 27, 2018

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 27, 2018

Done :)

@rbuels rbuels merged commit b43f949 into dev Feb 27, 2018

@wafflebot wafflebot bot removed the in progress label Feb 27, 2018

@rbuels rbuels deleted the loading_screen branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment