New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make subfeaturelevel default to 2 #1010

Merged
merged 3 commits into from Feb 27, 2018

Conversation

Projects
None yet
2 participants
@rbuels
Collaborator

rbuels commented Feb 27, 2018

This is a follow-on to #861, whic makes the feature detail popup only render one layer of subfeatures by default.

Since there is a 'Show subfeatures' button, this new default probably won't have any ill effects. And it should prevent most problems like the one in #559, in which the feature detail popup for a gene with a great many alternative transcripts (for several hundred features in total) takes upwards of 30 seconds to render all of the subfeature details, blocking the main UI thread all the while.

@rbuels rbuels added this to the 1.12.5 milestone Feb 27, 2018

@wafflebot wafflebot bot added the in progress label Feb 27, 2018

@rbuels rbuels requested a review from cmdcolin Feb 27, 2018

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Feb 27, 2018

Seems fine to me:)

@rbuels rbuels merged commit d265416 into dev Feb 27, 2018

@wafflebot wafflebot bot removed the in progress label Feb 27, 2018

@rbuels rbuels deleted the subfeature_level_default branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment