New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collective fixes regarding NeatCanvasFeatures and NeatHTMLFeatures #1011

Merged
merged 9 commits into from Mar 27, 2018

Conversation

Projects
None yet
2 participants
@enuggetry
Contributor

enuggetry commented Feb 28, 2018

consistify gradient on/off config option for NeatCanvasFeatures and NeatHTMLFeatures.
Restore NeatCanvasFeatures gradients #985,#982
add Outrons #992, #931
disable gradiants for alignment tracks #992
fixed uncaught typeerror #992
fixed gradient default NeatHTMLFeatures #992
cleanup docs

enuggetry added some commits Feb 28, 2018

collective fixes/additions
consistify gradient on/off config option for NeatCanvasFeatures and NeatHTMLFeatures.
Restore NeatCanvasFeatures gradients #985,#982
add Outrons #992, #931
disable gradiants for alignment tracks #992
fixed uncaught typeerror #992
fixed gradient default NeatHTMLFeatures #992

@enuggetry enuggetry added this to the 1.12.5 milestone Feb 28, 2018

@enuggetry enuggetry self-assigned this Feb 28, 2018

@wafflebot wafflebot bot added the in progress label Feb 28, 2018

@rbuels rbuels modified the milestones: 1.12.5, 1.13.0 Feb 28, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Feb 28, 2018

Almost there. Just had a look, it's throwing a JS error still. Pushing it back to the 1.13.0 milestone to give more time.

image

@rbuels rbuels modified the milestones: 1.13.0, 1.13.1 Mar 14, 2018

@rbuels rbuels merged commit e970e58 into dev Mar 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cmdcolin cmdcolin deleted the fix_neatplugins branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment