New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidetracklabels when nav is gone #1018

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented Mar 6, 2018

This PR fixes #1017 by checking for existence of a button before setting dom attributes, and checking for the config show_tracklabels to hide nodes

@wafflebot wafflebot bot added the in progress label Mar 6, 2018

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented Mar 6, 2018

Doesn't have a selenium test to check for the condition here but could add if interested

Could make PR change more minimal too, but did a little simultaeneous code cleanup

@rbuels rbuels merged commit 245d09b into dev Mar 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Mar 8, 2018

@rbuels rbuels added this to the 1.13.0 milestone Mar 8, 2018

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Mar 8, 2018

@cmdcolin oh, could you update this PR with a blurb in the release notes?

@rbuels

This comment has been minimized.

Collaborator

rbuels commented Mar 8, 2018

@cmdcolin and then I'll merge it again?

rbuels added a commit that referenced this pull request Mar 14, 2018

@cmdcolin cmdcolin deleted the fix_hide_tracklabels branch Mar 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment