New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check for node version #1048

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented May 8, 2018

Using node 10 gives this error

node v10.0.0 found, but node version 6 or later must be installed.

Modifying the comparison for node_major_version seems to fix it (ref https://stackoverflow.com/questions/18668556/comparing-numbers-in-bash)

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented May 8, 2018

Actually it looks like yarn needs to be upgraded also to update an error with upath using node 10. I don't have the right fix at the moment, but maybe some combo of running yarn upgrade or deleting yarn.lock and redoing yarn

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented May 10, 2018

Should be ok now :)

@rbuels rbuels added this to the 1.14.2 milestone May 28, 2018

@rbuels rbuels merged commit 3344a2c into dev May 31, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cmdcolin cmdcolin deleted the check_node_version branch Jun 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment