New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron app improvements #1050

Merged
merged 59 commits into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Contributor

cmdcolin commented May 14, 2018

This PR addresses

  1. not having an error on startup of electron, by shortcircuiting to the welcome page in browser.js
  2. restoring the delete icon on the sessions
  3. changing text from previous sessions to saved sessions
  4. removing the "your jbrowse is running in desktop mode" text

It also fixes a bug with electron resolveUrl and re-enables drag n drop files in the file open dialog

Unfortunately, re-enabling drag and drop caused spectron approach to be problematic. Basically it is unable to perform a click action on the dojox file uploader widget via the spectron chromedriver (error text: Other element would receive the click....dijitUnderlay)

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented May 14, 2018

xref #1045

@cmdcolin

This comment has been minimized.

Contributor

cmdcolin commented May 15, 2018

Got tests re-enabled. Had to switch from mocking the system file dialog to just entering data to the textfield but this seems to work fine for the purposes of testing :)

@rbuels rbuels added this to the 1.14.2 milestone May 28, 2018

@rbuels

rbuels approved these changes Jun 4, 2018

@rbuels rbuels merged commit e5aee18 into dev Jun 4, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@cmdcolin cmdcolin deleted the electron_polishing branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment