Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.sh error checking for node/npm #1083

Merged
merged 1 commit into from Jun 30, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Jun 30, 2018

We saw an issue when a user without NPM/node ran the setup.sh script that it would exit without giving a nice error message

I saw that this is likely due to set -e so this is disabled around this block. Additional version information is given in the error messages now also

@cmdcolin

This comment has been minimized.

Copy link
Contributor Author

cmdcolin commented Jun 30, 2018

See #1082

@rbuels rbuels added this to the 1.15.0 milestone Jun 30, 2018

@rbuels

This comment has been minimized.

Copy link
Collaborator

rbuels commented Jun 30, 2018

@cmdcolin needs a release note

@rbuels rbuels merged commit b8693ce into dev Jun 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Jun 30, 2018

@cmdcolin cmdcolin deleted the fix_setup_error_checking branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.