Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search dialog #1101

Merged
merged 15 commits into from Jul 13, 2018

Conversation

Projects
None yet
2 participants
@cmdcolin
Copy link
Contributor

cmdcolin commented Jul 9, 2018

This is a PR to add a View->Search popup box that searches the current name store for features that match a query. It uses both the "query" and "get" functions on the Name store so both those are considered a public interface.

screenshot-localhost-2018 07 09-19-47-55

This addresses #1081 and makes searching more accessible to users

Some design decision include

  • fully querying the store for complete records instead of waiting for an exact match to get complete record
  • allowing user to select "exact match only" via checkbox
  • listing all multiple matches that turn up

@wafflebot wafflebot bot added the in progress label Jul 9, 2018

@rbuels rbuels added this to the 1.15.0 milestone Jul 10, 2018

@rbuels rbuels added the has pullreq label Jul 11, 2018

@rbuels rbuels assigned cmdcolin and unassigned cmdcolin Jul 11, 2018

@cmdcolin cmdcolin force-pushed the add_search_dialog branch from 31f3ad3 to 73ad48d Jul 13, 2018

@cmdcolin cmdcolin force-pushed the add_search_dialog branch from f41b63f to 575162c Jul 13, 2018

@cmdcolin cmdcolin force-pushed the add_search_dialog branch from 77e81ca to c701f85 Jul 13, 2018

@cmdcolin cmdcolin merged commit deb4bcd into dev Jul 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@wafflebot wafflebot bot removed the in progress label Jul 13, 2018

@cmdcolin cmdcolin deleted the add_search_dialog branch Jul 17, 2018

@rbuels rbuels referenced this pull request Aug 31, 2018

Open

better searching #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.